Skip to content

[ci] get rid of ok-to-test label - #875

Merged
Andrei Kvapil (kvaps) merged 1 commit into
mainfrom
disable-ok-to-test
Apr 24, 2025
Merged

[ci] get rid of ok-to-test label#875
Andrei Kvapil (kvaps) merged 1 commit into
mainfrom
disable-ok-to-test

Conversation

@kvaps

@kvaps Andrei Kvapil (kvaps) commented Apr 24, 2025 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Github requires approval for external users anyway:

https://docs.github.com/en/actions/managing-workflow-runs-and-deployments/managing-workflow-runs/approving-workflow-runs-from-public-forks

Summary by CodeRabbit

  • Chores
    • Simplified conditions for running GitHub Actions workflows on pull requests, removing dependencies on the "ok-to-test" label and repository origin.
    • Updated comments to reflect the new workflow logic.

@kvaps
[ci] get rid of ok-to-test label
f9ec630 
Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
@coderabbitai

coderabbitai Bot commented Apr 24, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

The pull request updates the conditional logic in two GitHub Actions workflow files. In the "pull-requests-release.yaml" workflow, the condition for running the "verify" job is simplified by removing the requirement for the "ok-to-test" label, so it now only depends on the presence of the "release" label and the pull request not being closed. In the "pull-requests.yaml" workflow, the job's execution condition is also simplified to only check for the absence of the "release" label, eliminating logic related to repository origin and the "ok-to-test" label. Associated comments are updated or removed accordingly.

Changes

File(s) Change Summary
.github/workflows/pull-requests-release.yaml Simplified the "verify" job's conditional expression to require only the "release" label and that the PR is not closed; added a clarifying comment.
.github/workflows/pull-requests.yaml Simplified the job's conditional expression to require only the absence of the "release" label; removed related comments.

Suggested reviewers

  • NickVolynkin
  • lllamnyp
  • klinch0

Poem

Oh labels, how you guide the flow,
In YAML fields where actions grow.
"Ok-to-test," now gone from sight,
"Release" alone controls the light.
Simpler rules, a cleaner day—
The workflows hop a lighter way!
🐇✨

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@kvaps Andrei Kvapil (kvaps) added the backport Should change be backported on previous release label Apr 24, 2025
coderabbitai[bot]
coderabbitai Bot reviewed Apr 24, 2025
View reviewed changes

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
.github/workflows/pull-requests.yaml (1)

17-17: Review conditional trigger for forked pull requests
Removing the ok-to-test label check simplifies the logic but causes this job to run on all PRs that lack the release label—even from forks. Confirm that this aligns with your security policy and resource constraints, since it will execute CI on untrusted forked code (and may still have access to the GITHUB_TOKEN). If you need to restrict to the same repository, consider re-adding an origin check or limiting permissions.

.github/workflows/pull-requests-release.yaml (1)

15-18: Verify security and trigger semantics after dropping ok-to-test
The updated condition removes the ok-to-test check, so any PR with the release label—regardless of origin—will trigger this job on all pull_request events (opened, synchronize, reopened, labeled), except when closed. Ensure that only trusted collaborators can apply the release label to avoid executing on untrusted forks, or consider restricting event types to labeled if you only want a single run at labeling time.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3f47181 and f9ec630.

📒 Files selected for processing (2)
  • .github/workflows/pull-requests-release.yaml (1 hunks)
  • .github/workflows/pull-requests.yaml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Build and Test
  • GitHub Check: Build and Test

@kvaps
Andrei Kvapil (kvaps) merged commit d89acbf into main Apr 24, 2025
@kvaps
Andrei Kvapil (kvaps) deleted the disable-ok-to-test branch April 24, 2025 11:58
@github-actions

github-actions Bot commented Apr 24, 2025

Copy link
Copy Markdown

Git push to origin failed for release-0.30 with exitcode 1

@NickVolynkin Nick Volynkin (NickVolynkin) mentioned this pull request Apr 24, 2025
Closed
This was referenced Apr 25, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments
@lllamnyp Timofei Larkin (lllamnyp) Awaiting requested review from lllamnyp lllamnyp is a code owner
+1 more reviewer
@klinch0 klinch0 klinch0 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport Should change be backported on previous release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kvaps @klinch0