[kubernetes] Add gpu-operator and introduce GPU support for tenant Kubernetes clusters - #834

packages/apps/kubernetes/values.yaml (1)

153-153: Remove trailing whitespace
YAML linters flag trailing spaces. Please remove the extra space on this line to satisfy linting.

🧰 Tools

🪛 YAMLlint (1.35.1)

[error] 153-153: trailing spaces

(trailing-spaces)

packages/apps/kubernetes/README.md (1)

63-70: Refine grammar in resource-preset descriptions
The phrase "This is ignored if resources is set (resources is recommended for production)" uses singular/plural inconsistently. Consider updating to:

- ... Set container resources according to one common preset ... This is ignored if resources is set (resources is recommended for production).
+ ... Set container resources using a common preset ... These presets are ignored if specific resources are set (resources are recommended for production).

🧰 Tools

🪛 LanguageTool

[uncategorized] ~64-~64: This verb does not appear to agree with the subject. Consider using a different form.
Context: ... 2xlarge). This is ignored if resources is set (resources is recommended for produ...

(AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)

---

[uncategorized] ~64-~64: This verb does not appear to agree with the subject. Consider using a different form.
Context: ... ignored if resources is set (resources is recommended for production). | small ...

(AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)

---

[uncategorized] ~66-~66: This verb does not appear to agree with the subject. Consider using a different form.
Context: ... 2xlarge). This is ignored if resources is set (resources is recommended for produ...

(AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)

---

[uncategorized] ~66-~66: This verb does not appear to agree with the subject. Consider using a different form.
Context: ... ignored if resources is set (resources is recommended for production). | micro ...

(AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)

---

[uncategorized] ~68-~68: This verb does not appear to agree with the subject. Consider using a different form.
Context: ... 2xlarge). This is ignored if resources is set (resources is recommended for produ...

(AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)

---

[uncategorized] ~68-~68: This verb does not appear to agree with the subject. Consider using a different form.
Context: ... ignored if resources is set (resources is recommended for production). | micro ...

(AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)

---

[uncategorized] ~70-~70: This verb does not appear to agree with the subject. Consider using a different form.
Context: ... 2xlarge). This is ignored if resources is set (resources is recommended for produ...

(AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)

---

[uncategorized] ~70-~70: This verb does not appear to agree with the subject. Consider using a different form.
Context: ... ignored if resources is set (resources is recommended for production). | micro ...

(AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

packages/apps/kubernetes/values.yaml (1)

90-93: 🛠️ Refactor suggestion

Missing enabled flag for VerticalPodAutoscaler addon
For consistency with other addons (certManager, ingressNginx, gpuOperator, etc.), add an enabled: false field to addons.verticalPodAutoscaler. This makes it clear when the VPA component should be deployed.

packages/apps/kubernetes/README.md (1)

37-37: Fix typo in control plane description
There's still a typo in the controlPlane.replicas description:

• Change “contorl-plane” → “control-plane”

packages/apps/kubernetes/templates/helmreleases/gpu-operator.yaml (2)

7-8: ⚠️ Potential issue

Fix label key typo
The label key coztstack.io/target-cluster-name is misspelled. It should be cozystack.io/target-cluster-name to match your domain.

-    coztstack.io/target-cluster-name: {{ .Release.Name }}
+    cozystack.io/target-cluster-name: {{ .Release.Name }}

---

13-20: 🛠️ Refactor suggestion

Pin GPU Operator chart version
To ensure reproducible deployments, specify a version under chart.spec. For example:

   chart:
     spec:
       chart: cozy-gpu-operator
+      version: <gpu-operator-chart-version>
       reconcileStrategy: Revision
       sourceRef:
         kind: HelmRepository

packages/apps/kubernetes/values.yaml (1)

153-153: Remove trailing whitespace
There's a trailing space on this blank line (line 153), which can cause lint warnings. Please trim trailing spaces.

🧰 Tools

🪛 YAMLlint (1.35.1)

[error] 153-153: trailing spaces

(trailing-spaces)

packages/apps/kubernetes/README.md (1)

64-70: Refine grammar in resource preset descriptions
The repeated phrase “This is ignored if resources is set…” could be clearer. Consider rewording to “Ignored when resources is specified” or “This setting is ignored when custom resources are provided”.

🧰 Tools

🪛 LanguageTool

[uncategorized] ~64-~64: This verb does not appear to agree with the subject. Consider using a different form.
Context: ... 2xlarge). This is ignored if resources is set (resources is recommended for produ...

(AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)

---

[uncategorized] ~64-~64: This verb does not appear to agree with the subject. Consider using a different form.
Context: ... ignored if resources is set (resources is recommended for production). | small ...

(AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)

---

[uncategorized] ~66-~66: This verb does not appear to agree with the subject. Consider using a different form.
Context: ... 2xlarge). This is ignored if resources is set (resources is recommended for produ...

(AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)

---

[uncategorized] ~66-~66: This verb does not appear to agree with the subject. Consider using a different form.
Context: ... ignored if resources is set (resources is recommended for production). | micro ...

(AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)

---

[uncategorized] ~68-~68: This verb does not appear to agree with the subject. Consider using a different form.
Context: ... 2xlarge). This is ignored if resources is set (resources is recommended for produ...

(AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)

---

[uncategorized] ~68-~68: This verb does not appear to agree with the subject. Consider using a different form.
Context: ... ignored if resources is set (resources is recommended for production). | micro ...

(AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)

---

[uncategorized] ~70-~70: This verb does not appear to agree with the subject. Consider using a different form.
Context: ... 2xlarge). This is ignored if resources is set (resources is recommended for produ...

(AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)

---

[uncategorized] ~70-~70: This verb does not appear to agree with the subject. Consider using a different form.
Context: ... ignored if resources is set (resources is recommended for production). | micro ...

(AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

packages/apps/kubernetes/README.md (1)

37-37: Fix typo in controlPlane.replicas description
There's a typo in the description for controlPlane.replicas:

- Number of replicas for Kubernetes contorl-plane components
+ Number of replicas for Kubernetes control-plane components

packages/apps/kubernetes/templates/helmreleases/gpu-operator.yaml (1)

7-8: ⚠️ Potential issue

Fix label key typo
The label coztstack.io/target-cluster-name has a spelling error in the domain. It should be cozystack.io:

-     coztstack.io/target-cluster-name: {{ .Release.Name }}
+     cozystack.io/target-cluster-name: {{ .Release.Name }}

packages/apps/kubernetes/README.md (2)

40-40: Clarify nested path for gpus parameter
The table lists gpus at the top level, but this setting is actually nested under each nodeGroups entry. Consider renaming the "Name" column to nodeGroups[].gpus (or similar) for clarity.

---

155-155: Remove trailing spaces
Line 155 contains trailing whitespace that should be removed to satisfy YAML linting.

packages/apps/kubernetes/templates/helmreleases/gpu-operator.yaml (2)

11-11: Use unique Helm release name per cluster
Currently releaseName: gpu-operator is a static value. This may cause conflicts in shared namespaces. Consider:

-releaseName: gpu-operator
+releaseName: {{ .Release.Name }}-gpu-operator

---

13-16: Pin GPU Operator chart version
For reproducible deployments, explicitly specify the chart version under chart.spec:

 chart:
   spec:
     chart: cozy-gpu-operator
+    version: <gpu-operator-chart-version>
     reconcileStrategy: Revision

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

packages/apps/kubernetes/README.md (2)

37-37: ⚠️ Potential issue

Fix typo in parameter description
The description for controlPlane.replicas still reads contorl-plane. Please correct it to control-plane.

---

41-56: 🛠️ Refactor suggestion

Cluster Addons table consistency
The table lists all addons, including the new GPU operator and VPA overrides. However, unlike other addons, verticalPodAutoscaler only has valuesOverride and lacks an enabled flag. To maintain consistency, please add an addons.verticalPodAutoscaler.enabled row (default false) above its valuesOverride.

packages/apps/kubernetes/templates/helmreleases/gpu-operator.yaml (2)

7-8: ⚠️ Potential issue

Fix label key typo
The label key coztstack.io/target-cluster-name is misspelled and will break downstream selectors. It should read:

-    coztstack.io/target-cluster-name: {{ .Release.Name }}
+    cozystack.io/target-cluster-name: {{ .Release.Name }}

---

40-47: ⚠️ Potential issue

Correct indentation under dependsOn
YAML sequences must be indented under their parent key. Update as follows:

-  dependsOn:
-  - name: {{ .Release.Name }}
-    namespace: {{ .Release.Namespace }}
+  dependsOn:
+    - name: {{ .Release.Name }}
+      namespace: {{ .Release.Namespace }}
     {{- end }}
+    - name: {{ .Release.Name }}-cilium
+      namespace: {{ .Release.Namespace }}

This ensures valid YAML and proper dependency ordering.

packages/apps/kubernetes/values.schema.json (1)

108-118: 🛠️ Refactor suggestion

Add missing enabled flag for Vertical Pod Autoscaler
To align with other addons, include an enabled boolean before valuesOverride (default false).

Apply this diff:

 "verticalPodAutoscaler": {
     "type": "object",
     "properties": {
+        "enabled": {
+            "type": "boolean",
+            "description": "Enables the Vertical Pod Autoscaler",
+            "default": false
+        },
         "valuesOverride": {
             "type": "object",
             "description": "Custom values to override",
             "default": {}
         }

packages/apps/kubernetes/values.yaml (1)

154-154: Remove trailing spaces
There's a trailing whitespace on this line. Removing it will keep the YAML clean and avoid linter warnings.

🧰 Tools

🪛 YAMLlint (1.35.1)

[error] 154-154: trailing spaces

(trailing-spaces)

packages/apps/kubernetes/templates/helmreleases/gpu-operator.yaml (1)

12-19: Pin GPU Operator chart version
For reproducible deployments, specify a chart version under chart.spec. For example:

   chart:
     spec:
       chart: cozy-gpu-operator
+      version: <gpu-operator-chart-version>
       reconcileStrategy: Revision
       sourceRef:
         kind: HelmRepository

packages/apps/kubernetes/values.schema.json (1)

132-136: Restrict resourcesPreset to allowed values
To enforce only valid presets, add an enum constraint for resourcesPreset (none, nano, micro, small, medium, large, xlarge, 2xlarge).

Example diff for the apiServer.resourcesPreset:

- "resourcesPreset": {
-     "type": "string",
-     "description": "...",
-     "default": "small"
- },
+ "resourcesPreset": {
+     "type": "string",
+     "enum": ["none","nano","micro","small","medium","large","xlarge","2xlarge"],
+     "description": "...",
+     "default": "small"
+ },

Remember to propagate this to all resourcesPreset definitions under kamajiControlPlane.

packages/apps/kubernetes/values.yaml (1)

27-32: ⚠️ Potential issue

Mismatch between gpus example and schema
The inline example shows each GPU as an object with a name key, but the JSON schema defines gpus items as plain strings. Please reconcile this by either:

• Updating the schema to accept objects with a name field, or
• Changing the example to a simple list of device strings (e.g. - "nvidia.com/AD102GL_L40S").

packages/apps/kubernetes/templates/helmreleases/gpu-operator.yaml (2)

12-15: 🛠️ Refactor suggestion

Pin GPU Operator chart version
For reproducible deployments, specify a version under chart.spec.

Example diff:

 chart:
   spec:
     chart: cozy-gpu-operator
+    version: <gpu-operator-chart-version>

---

40-47: ⚠️ Potential issue

Fix indentation of dependsOn entries
Sequence items under dependsOn must be indented beneath the key. This ensures valid YAML for HelmRelease dependencies.

Suggested diff:

 spec:
   dependsOn:
-  {{- if lookup "helm.toolkit.fluxcd.io/v2" "HelmRelease" .Release.Namespace .Release.Name }}
-  - name: {{ .Release.Name }}
-    namespace: {{ .Release.Namespace }}
-  {{- end }}
-  - name: {{ .Release.Name }}-cilium
-    namespace: {{ .Release.Namespace }}
+  {{- if lookup "helm.toolkit.fluxcd.io/v2" "HelmRelease" .Release.Namespace .Release.Name }}
+    - name: {{ .Release.Name }}
+      namespace: {{ .Release.Namespace }}
+  {{- end }}
+    - name: {{ .Release.Name }}-cilium
+      namespace: {{ .Release.Namespace }}

packages/apps/kubernetes/values.yaml (1)

154-154: Remove trailing spaces
There’s a trailing space on this line. Please delete the extra whitespace to satisfy YAML linting.

🧰 Tools

🪛 YAMLlint (1.35.1)

[error] 154-154: trailing spaces

(trailing-spaces)

packages/apps/kubernetes/README.md (3)

34-39: Document gpus under nodeGroups
The common parameters table lists nodeGroups but doesn’t mention the new gpus field. Consider extending the description for nodeGroups or adding a separate row for nodeGroups[].gpus.

---

50-56: Cluster Addons table updated

• Approve the addition of addons.gpuOperator.enabled and valuesOverride.
• For consistency, add an addons.verticalPodAutoscaler.enabled (default false) flag before the valuesOverride entry.

---

63-69: Grammar tweak for resource presets
The sentence “resources is recommended for production” should agree in number. Consider:

- (resources is recommended for production).
+ (resources are recommended for production).

🧰 Tools

🪛 LanguageTool

[uncategorized] ~63-~63: This verb does not appear to agree with the subject. Consider using a different form.
Context: ... 2xlarge). This is ignored if resources is set (resources is recommended for produ...

(AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)

---

[uncategorized] ~63-~63: This verb does not appear to agree with the subject. Consider using a different form.
Context: ... ignored if resources is set (resources is recommended for production). | small ...

(AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)

---

[uncategorized] ~65-~65: This verb does not appear to agree with the subject. Consider using a different form.
Context: ... 2xlarge). This is ignored if resources is set (resources is recommended for produ...

(AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)

---

[uncategorized] ~65-~65: This verb does not appear to agree with the subject. Consider using a different form.
Context: ... ignored if resources is set (resources is recommended for production). | micro ...

(AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)

---

[uncategorized] ~67-~67: This verb does not appear to agree with the subject. Consider using a different form.
Context: ... 2xlarge). This is ignored if resources is set (resources is recommended for produ...

(AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)

---

[uncategorized] ~67-~67: This verb does not appear to agree with the subject. Consider using a different form.
Context: ... ignored if resources is set (resources is recommended for production). | micro ...

(AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)

---

[uncategorized] ~69-~69: This verb does not appear to agree with the subject. Consider using a different form.
Context: ... 2xlarge). This is ignored if resources is set (resources is recommended for produ...

(AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)

---

[uncategorized] ~69-~69: This verb does not appear to agree with the subject. Consider using a different form.
Context: ... ignored if resources is set (resources is recommended for production). | micro ...

(AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro