Skip to content

[k8s] change CP default resourcesPreset - #758

Merged
Andrei Kvapil (kvaps) merged 1 commit into
cozystack:mainfrom
klinch0:k8s-change-CP-default-resourcesPreset
Apr 5, 2025
Merged

[k8s] change CP default resourcesPreset#758
Andrei Kvapil (kvaps) merged 1 commit into
cozystack:mainfrom
klinch0:k8s-change-CP-default-resourcesPreset

Conversation

@klinch0

@klinch0 klinch0 commented Apr 5, 2025 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Chores

    • Updated the release version to 0.17.1 and refined version mapping for improved stability.

  • New Features

    • Adjusted the default API server resource allocation preset to a larger profile, enhancing performance.

@klinch0
[k8s] change CP default resourcesPreset
3cf850c 
Signed-off-by: kklinch0 <kklinch0@gmail.com>
@coderabbitai

coderabbitai Bot commented Apr 5, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

The pull request updates configuration files for a Kubernetes chart release. In Chart.yaml, the chart version is incremented from 0.17.0 to 0.17.1. The values.yaml file now sets the kamajiControlPlane.apiServer.resourcesPreset parameter from "micro" to "small". Additionally, the versions_map file is modified by updating the 0.17.0 version entry to reference a specific commit hash and by adding a new entry for version 0.17.1.

Changes

File(s) Change Summary
packages/apps/kubernetes/Chart.yaml
packages/apps/.../versions_map		 Chart.yaml: Updated chart version from 0.17.0 to 0.17.1.
versions_map: Changed 0.17.0 entry from HEAD to commit 1fbbfcd0 and added new 0.17.1 entry as HEAD.
packages/apps/kubernetes/values.yaml Updated the kamajiControlPlane.apiServer.resourcesPreset parameter from "micro" to "small".

Poem

I'm a rabbit with a skip and a hop,
Celebrating changes that never stop.
New versions bloom in YAML's sun,
Small resource tweaks and commits spun.
Hopping through updates with a joyful pop!
🥕🐇

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1fbbfcd and 3cf850c.

📒 Files selected for processing (3)
  • packages/apps/kubernetes/Chart.yaml (1 hunks)
  • packages/apps/kubernetes/values.yaml (1 hunks)
  • packages/apps/versions_map (1 hunks)
🔇 Additional comments (3)
packages/apps/kubernetes/Chart.yaml (1)

19-19: Version increment looks good.

The chart version has been properly incremented from 0.17.0 to 0.17.1, which is appropriate for the non-breaking change being made to the default resourcesPreset value.

packages/apps/versions_map (1)

59-60: Versioning update is correct.

The changes correctly:

  1. Pin the previous version (0.17.0) to a specific commit hash (1fbbfcd)
  2. Add the new version (0.17.1) as HEAD

This follows the proper pattern for version management in this repository.

packages/apps/kubernetes/values.yaml (1)

88-88: Resource preset upgrade looks good.

Changing the API server's resourcesPreset from "micro" to "small" will provide more resources to this critical component, which should improve performance and stability. This change only affects the API server while other control plane components remain at "micro" preset.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@klinch0
klinch0 marked this pull request as ready for review April 5, 2025 18:32
kvaps
Andrei Kvapil (kvaps) approved these changes Apr 5, 2025
View reviewed changes

@kvaps Andrei Kvapil (kvaps) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kvaps Andrei Kvapil (kvaps) added the ok-to-test Indicates a non-member PR is safe to run CI on label Apr 5, 2025
@kvaps
Andrei Kvapil (kvaps) merged commit 49b5b51 into cozystack:main Apr 5, 2025
@coderabbitai coderabbitai Bot mentioned this pull request Apr 22, 2025
Merged
@coderabbitai coderabbitai Bot mentioned this pull request Jun 16, 2025
Merged
@coderabbitai coderabbitai Bot mentioned this pull request Jun 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kvaps Andrei Kvapil (kvaps) kvaps approved these changes
@lllamnyp Timofei Larkin (lllamnyp) Awaiting requested review from lllamnyp lllamnyp is a code owner
+1 more reviewer
@xy2 xy2 xy2 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ok-to-test Indicates a non-member PR is safe to run CI on

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@klinch0 @xy2 @kvaps