Skip to content

Add analyzer/fix for redudant field initializers#336

Merged
carloscds merged 1 commit intocode-cracker:masterfrom
giggio:redundant-field
May 14, 2015
Merged

Add analyzer/fix for redudant field initializers#336
carloscds merged 1 commit intocode-cracker:masterfrom
giggio:redundant-field

Conversation

@giggio
Copy link
Copy Markdown
Member

@giggio giggio commented May 11, 2015

closes #9

PR created from Greece during my vacations! :) ☀️

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.0%) to 90.14% when pulling ac65121 on giggio:redundant-field into f689d48 on code-cracker:master.

@carloscds carloscds self-assigned this May 11, 2015
@giggio giggio force-pushed the redundant-field branch from ac65121 to e73ef1e Compare May 13, 2015 14:29
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.0%) to 90.17% when pulling e73ef1e on giggio:redundant-field into 69418ae on code-cracker:master.

@carloscds
Copy link
Copy Markdown

@giggio This test is breaking: public async Task ComputeExpression(string original, string fix) =>
await VerifyCSharpFixAsync(original.WrapInCSharpMethod(), fix.WrapInCSharpMethod());
image

@giggio
Copy link
Copy Markdown
Member Author

giggio commented May 14, 2015

Hm... same problem of globalization again, I will check it out.

@giggio
Copy link
Copy Markdown
Member Author

giggio commented May 14, 2015

@carloscds This test ComputeExpression is not from this Pull Request. This PR is about redundant fields, and I did not change the CompureExpression files, as you can see from the commits.
You had already caught this error on #312, and I had already fixed it. We even worked on #313 because of it, remember?
Are you up to date with the master branch?

@carloscds
Copy link
Copy Markdown

@giggio Yes, I know this. My suggestion is open a bug to solve this.

@giggio
Copy link
Copy Markdown
Member Author

giggio commented May 14, 2015

@carloscds I can't repro. As I told you, I already fixed that bug. See this line:
https://github.com/code-cracker/code-cracker/blob/master/src/CSharp/CodeCracker/Refactoring/ComputeExpressionCodeFixProvider.cs#L51
Is this PR ok?

@carloscds
Copy link
Copy Markdown

@giggio I remember this, but now in RC I have same bug when I run tests.

@giggio
Copy link
Copy Markdown
Member Author

giggio commented May 14, 2015

Ok @carloscds, bug #339 opened for that unrelated issue.

How about this specific PR? Is it ok?

carloscds pushed a commit that referenced this pull request May 14, 2015
Add analyzer/fix for redudant field initializers
@carloscds carloscds merged commit 2c2cb8f into code-cracker:master May 14, 2015
@giggio giggio deleted the redundant-field branch May 14, 2015 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Supress assignment of default value to field/property declarations

3 participants