Add compute value of an expression analyzer#312
Merged
carloscds merged 1 commit intocode-cracker:masterfrom Apr 17, 2015
Merged
Add compute value of an expression analyzer#312carloscds merged 1 commit intocode-cracker:masterfrom
carloscds merged 1 commit intocode-cracker:masterfrom
Conversation
There was a problem hiding this comment.
@giggio This line is produce an error in value because of culture. Result value is 2.4 and after result.Value.ToString() is 2,4. and two tests fail.
Member
Author
There was a problem hiding this comment.
@carloscds I have updated it, but I can't test it, because my system is in en-US. Can you please verify?
Member
Author
There was a problem hiding this comment.
Nice! @carloscds @ElemarJR Do you have any idea on how we could add a unit test to verify this?
There was a problem hiding this comment.
Member
Author
There was a problem hiding this comment.
@carloscds @ElemarJR I am not sure how to solve this. I created issue #313 so we can discuss there.
c256b25 to
4e43d33
Compare
carloscds
pushed a commit
that referenced
this pull request
Apr 17, 2015
Add compute value of an expression analyzer
This was referenced May 14, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #117