Skip to content

Fix #15 by adding . (dot) between event type name and version if missing #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zaza wants to merge 3 commits into from
Closed

Fix #15 by adding . (dot) between event type name and version if missing #24

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8a63adf
Fix #15 by adding . (dot) between event type name and version
zaza Apr 18, 2023
9311b7c
Make the event type name pattern even more strict.
zaza Apr 18, 2023
dfe33a2
Merge branch 'main' into 15/missing-dot-in-event-types
zaza Apr 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge branch 'main' into 15/missing-dot-in-event-types
  • Loading branch information
@zaza
zaza authored Apr 19, 2023
commit dfe33a275f8a113681880d82e4347994754db2c9
6 changes: 6 additions & 0 deletions src/test/java/dev/cdevents/constants/CDEventTypesTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,10 @@ void allEventTypeNamesMatchExpectedPattern() {
assertThat(CDEventTypes.values()).extracting(CDEventTypes::getEventType)
.allMatch(type -> type.matches("dev\\.cdevents\\.[a-z]+\\.[a-z]+\\.\\d+\\.\\d+\\.\\d+"));
}

@Test
void eventTypeNamesAreUnique() {
assertThat(CDEventTypes.values()).extracting(CDEventTypes::getEventType).doesNotHaveDuplicates();
}
}

You are viewing a condensed version of this merge commit. You can view the full changes here.