Skip to content

Fix #15 by adding . (dot) between event type name and version if missing - #24

Closed
zaza wants to merge 3 commits into
cdevents:mainfrom
zaza:15/missing-dot-in-event-types
Closed

Fix #15 by adding . (dot) between event type name and version if missing#24
zaza wants to merge 3 commits into
cdevents:mainfrom
zaza:15/missing-dot-in-event-types

Conversation

@zaza

@zaza zaza commented Apr 18, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@zaza zaza changed the title Fix #15 by adding . (dot) between event type name and version Fix #15 by adding . (dot) between event type name and version if missing Apr 18, 2023
Comment thread src/test/java/dev/cdevents/constants/CDEventTypesTest.java Outdated
@zaza
zaza requested a review from afrittoli April 18, 2023 12:59

@afrittoli afrittoli left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@zaza

zaza commented Apr 19, 2023

Copy link
Copy Markdown
Contributor Author

@afrittoli seems like the /approve trick didn't work, this PR still requires a review.

@afrittoli

Copy link
Copy Markdown
Member

@zaza heh, we don't have prow installed, silly me - if you rebase the PR I will merge it then

@afrittoli

Copy link
Copy Markdown
Member

Thanks for the update. Could you please remove the merge commit from the PR?

@zaza

zaza commented Apr 19, 2023

Copy link
Copy Markdown
Contributor Author

I'm sorry, I thought you're able to squash and merge the PR.

@afrittoli

Copy link
Copy Markdown
Member

I'm sorry, I thought you're able to squash and merge the PR.

No worries, probably the squash will remove the merge commit, let me try :)

@rjalander

Copy link
Copy Markdown
Contributor

@zaza @afrittoli, Currently refactoring the code the way we need to create a CDEvent as per the latest spec.
and here we used CDEvents Spec Version instead of event version as per the comment #35 (comment)

As per my knowledge will not be using https://github.com/cdevents/sdk-java/blob/main/src/main/java/dev/cdevents/CDEventTypes.java, once this PR is available with all other events #35

@afrittoli

Copy link
Copy Markdown
Member

@zaza @afrittoli, Currently refactoring the code the way we need to create a CDEvent as per the latest spec. and here we used CDEvents Spec Version instead of event version as per the comment #35 (comment)

As per my knowledge will not be using https://github.com/cdevents/sdk-java/blob/main/src/main/java/dev/cdevents/CDEventTypes.java, once this PR is available with all other events #35

Thanks, @zaza for this PR and @rjalander for your comment.
It sounds like we should be closing this one then - @zaza your contributions are very welcome nonetheless!
I assigned issues that are covered by #35 to @rjalander, to avoid double work on any of those.

@zaza in case you'd like to chat about the SDK and CDEvents, we have a #cdevents channel on the CDF slack, a mailing list and weekly working groups.

@zaza

zaza commented Apr 27, 2023

Copy link
Copy Markdown
Contributor Author

Closing the PR as requested.

@zaza zaza closed this Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants