Skip to content

feat: Python 3.9 for readthedocs - #2973

Merged
ahsan-z-khan merged 8 commits into
aws:devfrom
ahsan-z-khan:rtd-py
Mar 8, 2022
Merged

feat: Python 3.9 for readthedocs#2973
ahsan-z-khan merged 8 commits into
aws:devfrom
ahsan-z-khan:rtd-py

Conversation

@ahsan-z-khan

@ahsan-z-khan ahsan-z-khan commented Mar 7, 2022

Copy link
Copy Markdown
Contributor

Issue #, if available:

Description of changes:
Updated python environment version for generating readthedocs docstrings
Testing done:
tox -e sphinx in python3.9 env

The HTML pages are in _build/html.
____________________________________________________________________ summary _____________________________________________________________________
  sphinx: commands succeeded
  congratulations :)

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Co-authored-by: Ben Crabtree bencrab@amazon.com
Co-authored-by: Navin Soni navinsoni89@gmail.com
Co-authored-by: Jeniya Tabassum jeniya.tabassum@gmail.com
Co-authored-by: Dewen Qi qidewen@amazon.com

navinsoni and others added 8 commits March 4, 2022 09:17
@navinsoni @shreyapandit
change: update code to get commit_id in codepipeline (aws#2961)
4883b2e
@jeniyat @shreyapandit
feature: Data Serializer (aws#2956)
d292ee1
@qidewenwhen @bencrabtree
@navinsoni @jeniyat Dewen Qi @shreyapandit
change: reorganize test files for workflow (aws#2960)
f727dae 
Co-authored-by: Ben Crabtree <bencrab@amazon.com>
Co-authored-by: Navin Soni <navinsoni89@gmail.com>
Co-authored-by: Jeniya Tabassum <jeniya.tabassum@gmail.com>
Co-authored-by: Dewen Qi <qidewen@amazon.com>
@Qingzi-Lan @bencrabtree
@navinsoni @jeniyat @shreyapandit
feature: TensorFlow 2.4 for Neo (aws#2861)
b1340e7 
Co-authored-by: Ben Crabtree <bencrab@amazon.com>
Co-authored-by: Navin Soni <navinsoni89@gmail.com>
Co-authored-by: Jeniya Tabassum <jeniya.tabassum@gmail.com>
@staubhp Payton Staub @shreyapandit
fix: Remove sagemaker_job_name from hyperparameters in TrainingStep (a…
067cac2 
…ws#2950)

Co-authored-by: Payton Staub <pstaub@amazon.com>
@jeniyat @shreyapandit
fix: Style update in DataSerializer (aws#2962)
253a275
@ahsan-z-khan
update rtd py version
09fe269
@ahsan-z-khan
Merge branch 'dev' into rtd-py
c6db291
@sagemaker-bot

sagemaker-bot commented Mar 7, 2022

Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: c6db291
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot

sagemaker-bot commented Mar 7, 2022

Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 09fe269
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot

sagemaker-bot commented Mar 7, 2022

Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: c6db291
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot

sagemaker-bot commented Mar 7, 2022

Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: c6db291
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot

sagemaker-bot commented Mar 7, 2022

Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 09fe269
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot

sagemaker-bot commented Mar 7, 2022

Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 09fe269
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@ahsan-z-khan
ahsan-z-khan merged commit 4325fcd into aws:dev Mar 8, 2022
@ahsan-z-khan
ahsan-z-khan deleted the rtd-py branch March 8, 2022 01:28
navinsoni added a commit that referenced this pull request Mar 9, 2022
@ahsan-z-khan @bencrabtree
@navinsoni @jeniyat Dewen Qi Payton Staub @qidewenwhen @Qingzi-Lan @staubhp @navinns
feat: Python 3.9 for readthedocs (#2973)
a30c7b5 
Co-authored-by: Ben Crabtree <bencrab@amazon.com>
Co-authored-by: Navin Soni <navinsoni89@gmail.com>
Co-authored-by: Jeniya Tabassum <jeniya.tabassum@gmail.com>
Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Payton Staub <pstaub@amazon.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>
Co-authored-by: Qingzi-Lan <83724147+Qingzi-Lan@users.noreply.github.com>
Co-authored-by: Payton Staub <staubhpa@gmail.com>
jeniyat added a commit that referenced this pull request Mar 18, 2022
@mchoi8739 @navinsoni
@jeniyat @qidewenwhen @bencrabtree Dewen Qi @Qingzi-Lan @staubhp Payton Staub @shreyapandit @ahsan-z-khan @mufaddal-rohawala
documentation: sagemaker distributed model parallel 1.7.0 doc (#2992)
b3660b9 
* change: update code to get commit_id in codepipeline (#2961)

* feature: Data Serializer (#2956)

* change: reorganize test files for workflow (#2960)

Co-authored-by: Ben Crabtree <bencrab@amazon.com>
Co-authored-by: Navin Soni <navinsoni89@gmail.com>
Co-authored-by: Jeniya Tabassum <jeniya.tabassum@gmail.com>
Co-authored-by: Dewen Qi <qidewen@amazon.com>

* feature: TensorFlow 2.4 for Neo (#2861)

Co-authored-by: Ben Crabtree <bencrab@amazon.com>
Co-authored-by: Navin Soni <navinsoni89@gmail.com>
Co-authored-by: Jeniya Tabassum <jeniya.tabassum@gmail.com>

* fix: Remove sagemaker_job_name from hyperparameters in TrainingStep (#2950)

Co-authored-by: Payton Staub <pstaub@amazon.com>

* fix: Style update in DataSerializer (#2962)

* documentation: smddp doc update (#2968)

* fix: container env generation for S3 URI and add test for the same (#2971)

* documentation: update sagemaker training compiler docstring (#2969)

* feat: Python 3.9 for readthedocs (#2973)

Co-authored-by: Ben Crabtree <bencrab@amazon.com>
Co-authored-by: Navin Soni <navinsoni89@gmail.com>
Co-authored-by: Jeniya Tabassum <jeniya.tabassum@gmail.com>
Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Payton Staub <pstaub@amazon.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>
Co-authored-by: Qingzi-Lan <83724147+Qingzi-Lan@users.noreply.github.com>
Co-authored-by: Payton Staub <staubhpa@gmail.com>

* fix doc structure

* archive 1.6.0 doc

* add new args, refs, and links

* fix version number

* incorp eng feedback, update docstrings, improve xref

* Trigger Build

* minor fix, trigger build again

* fix typo

Co-authored-by: Navin Soni <navinsoni89@gmail.com>
Co-authored-by: Jeniya Tabassum <jeniya.tabassum@gmail.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>
Co-authored-by: Ben Crabtree <bencrab@amazon.com>
Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Qingzi-Lan <83724147+Qingzi-Lan@users.noreply.github.com>
Co-authored-by: Payton Staub <staubhpa@gmail.com>
Co-authored-by: Payton Staub <pstaub@amazon.com>
Co-authored-by: Shreya Pandit <shreya.pandit25@gmail.com>
Co-authored-by: Ahsan Khan <ahsan.al.zaki@gmail.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
ahsan-z-khan added a commit to ahsan-z-khan/sagemaker-python-sdk that referenced this pull request Mar 23, 2022
@mchoi8739 @navinsoni
@jeniyat @qidewenwhen @bencrabtree Dewen Qi @Qingzi-Lan @staubhp Payton Staub @shreyapandit @ahsan-z-khan @mufaddal-rohawala
documentation: sagemaker distributed model parallel 1.7.0 doc (aws#2992)
ddb3fe9 
* change: update code to get commit_id in codepipeline (aws#2961)

* feature: Data Serializer (aws#2956)

* change: reorganize test files for workflow (aws#2960)

Co-authored-by: Ben Crabtree <bencrab@amazon.com>
Co-authored-by: Navin Soni <navinsoni89@gmail.com>
Co-authored-by: Jeniya Tabassum <jeniya.tabassum@gmail.com>
Co-authored-by: Dewen Qi <qidewen@amazon.com>

* feature: TensorFlow 2.4 for Neo (aws#2861)

Co-authored-by: Ben Crabtree <bencrab@amazon.com>
Co-authored-by: Navin Soni <navinsoni89@gmail.com>
Co-authored-by: Jeniya Tabassum <jeniya.tabassum@gmail.com>

* fix: Remove sagemaker_job_name from hyperparameters in TrainingStep (aws#2950)

Co-authored-by: Payton Staub <pstaub@amazon.com>

* fix: Style update in DataSerializer (aws#2962)

* documentation: smddp doc update (aws#2968)

* fix: container env generation for S3 URI and add test for the same (aws#2971)

* documentation: update sagemaker training compiler docstring (aws#2969)

* feat: Python 3.9 for readthedocs (aws#2973)

Co-authored-by: Ben Crabtree <bencrab@amazon.com>
Co-authored-by: Navin Soni <navinsoni89@gmail.com>
Co-authored-by: Jeniya Tabassum <jeniya.tabassum@gmail.com>
Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Payton Staub <pstaub@amazon.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>
Co-authored-by: Qingzi-Lan <83724147+Qingzi-Lan@users.noreply.github.com>
Co-authored-by: Payton Staub <staubhpa@gmail.com>

* fix doc structure

* archive 1.6.0 doc

* add new args, refs, and links

* fix version number

* incorp eng feedback, update docstrings, improve xref

* Trigger Build

* minor fix, trigger build again

* fix typo

Co-authored-by: Navin Soni <navinsoni89@gmail.com>
Co-authored-by: Jeniya Tabassum <jeniya.tabassum@gmail.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>
Co-authored-by: Ben Crabtree <bencrab@amazon.com>
Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Qingzi-Lan <83724147+Qingzi-Lan@users.noreply.github.com>
Co-authored-by: Payton Staub <staubhpa@gmail.com>
Co-authored-by: Payton Staub <pstaub@amazon.com>
Co-authored-by: Shreya Pandit <shreya.pandit25@gmail.com>
Co-authored-by: Ahsan Khan <ahsan.al.zaki@gmail.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
jerrypeng7773 pushed a commit to jerrypeng7773/sagemaker-python-sdk that referenced this pull request May 13, 2022
@mchoi8739 @navinsoni
@jeniyat @qidewenwhen @bencrabtree Dewen Qi @Qingzi-Lan @staubhp Payton Staub @shreyapandit @ahsan-z-khan @mufaddal-rohawala @jerrypeng7773
documentation: sagemaker distributed model parallel 1.7.0 doc (aws#2992)
c9539bd 
* change: update code to get commit_id in codepipeline (aws#2961)

* feature: Data Serializer (aws#2956)

* change: reorganize test files for workflow (aws#2960)

Co-authored-by: Ben Crabtree <bencrab@amazon.com>
Co-authored-by: Navin Soni <navinsoni89@gmail.com>
Co-authored-by: Jeniya Tabassum <jeniya.tabassum@gmail.com>
Co-authored-by: Dewen Qi <qidewen@amazon.com>

* feature: TensorFlow 2.4 for Neo (aws#2861)

Co-authored-by: Ben Crabtree <bencrab@amazon.com>
Co-authored-by: Navin Soni <navinsoni89@gmail.com>
Co-authored-by: Jeniya Tabassum <jeniya.tabassum@gmail.com>

* fix: Remove sagemaker_job_name from hyperparameters in TrainingStep (aws#2950)

Co-authored-by: Payton Staub <pstaub@amazon.com>

* fix: Style update in DataSerializer (aws#2962)

* documentation: smddp doc update (aws#2968)

* fix: container env generation for S3 URI and add test for the same (aws#2971)

* documentation: update sagemaker training compiler docstring (aws#2969)

* feat: Python 3.9 for readthedocs (aws#2973)

Co-authored-by: Ben Crabtree <bencrab@amazon.com>
Co-authored-by: Navin Soni <navinsoni89@gmail.com>
Co-authored-by: Jeniya Tabassum <jeniya.tabassum@gmail.com>
Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Payton Staub <pstaub@amazon.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>
Co-authored-by: Qingzi-Lan <83724147+Qingzi-Lan@users.noreply.github.com>
Co-authored-by: Payton Staub <staubhpa@gmail.com>

* fix doc structure

* archive 1.6.0 doc

* add new args, refs, and links

* fix version number

* incorp eng feedback, update docstrings, improve xref

* Trigger Build

* minor fix, trigger build again

* fix typo

Co-authored-by: Navin Soni <navinsoni89@gmail.com>
Co-authored-by: Jeniya Tabassum <jeniya.tabassum@gmail.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>
Co-authored-by: Ben Crabtree <bencrab@amazon.com>
Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Qingzi-Lan <83724147+Qingzi-Lan@users.noreply.github.com>
Co-authored-by: Payton Staub <staubhpa@gmail.com>
Co-authored-by: Payton Staub <pstaub@amazon.com>
Co-authored-by: Shreya Pandit <shreya.pandit25@gmail.com>
Co-authored-by: Ahsan Khan <ahsan.al.zaki@gmail.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
Evan-W-ang added a commit to Evan-W-ang/sagemaker-python-sdk that referenced this pull request Jun 8, 2026
@Evan-W-ang @bencrabtree
@navinsoni @jeniyat Dewen Qi Payton Staub @qidewenwhen @Qingzi-Lan @staubhp
feat: Python 3.9 for readthedocs (aws#2973)
450ea33 
Co-authored-by: Ben Crabtree <bencrab@amazon.com>
Co-authored-by: Navin Soni <navinsoni89@gmail.com>
Co-authored-by: Jeniya Tabassum <jeniya.tabassum@gmail.com>
Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Payton Staub <pstaub@amazon.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>
Co-authored-by: Qingzi-Lan <83724147+Qingzi-Lan@users.noreply.github.com>
Co-authored-by: Payton Staub <staubhpa@gmail.com>
Evan-W-ang added a commit to Evan-W-ang/sagemaker-python-sdk that referenced this pull request Jun 8, 2026
@Evan-W-ang @navinsoni
@jeniyat @qidewenwhen @bencrabtree Dewen Qi @Qingzi-Lan @staubhp Payton Staub @shreyapandit @ahsan-z-khan @mufaddal-rohawala
documentation: sagemaker distributed model parallel 1.7.0 doc (aws#2992)
516e90e 
* change: update code to get commit_id in codepipeline (aws#2961)

* feature: Data Serializer (aws#2956)

* change: reorganize test files for workflow (aws#2960)

Co-authored-by: Ben Crabtree <bencrab@amazon.com>
Co-authored-by: Navin Soni <navinsoni89@gmail.com>
Co-authored-by: Jeniya Tabassum <jeniya.tabassum@gmail.com>
Co-authored-by: Dewen Qi <qidewen@amazon.com>

* feature: TensorFlow 2.4 for Neo (aws#2861)

Co-authored-by: Ben Crabtree <bencrab@amazon.com>
Co-authored-by: Navin Soni <navinsoni89@gmail.com>
Co-authored-by: Jeniya Tabassum <jeniya.tabassum@gmail.com>

* fix: Remove sagemaker_job_name from hyperparameters in TrainingStep (aws#2950)

Co-authored-by: Payton Staub <pstaub@amazon.com>

* fix: Style update in DataSerializer (aws#2962)

* documentation: smddp doc update (aws#2968)

* fix: container env generation for S3 URI and add test for the same (aws#2971)

* documentation: update sagemaker training compiler docstring (aws#2969)

* feat: Python 3.9 for readthedocs (aws#2973)

Co-authored-by: Ben Crabtree <bencrab@amazon.com>
Co-authored-by: Navin Soni <navinsoni89@gmail.com>
Co-authored-by: Jeniya Tabassum <jeniya.tabassum@gmail.com>
Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Payton Staub <pstaub@amazon.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>
Co-authored-by: Qingzi-Lan <83724147+Qingzi-Lan@users.noreply.github.com>
Co-authored-by: Payton Staub <staubhpa@gmail.com>

* fix doc structure

* archive 1.6.0 doc

* add new args, refs, and links

* fix version number

* incorp eng feedback, update docstrings, improve xref

* Trigger Build

* minor fix, trigger build again

* fix typo

Co-authored-by: Navin Soni <navinsoni89@gmail.com>
Co-authored-by: Jeniya Tabassum <jeniya.tabassum@gmail.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>
Co-authored-by: Ben Crabtree <bencrab@amazon.com>
Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Qingzi-Lan <83724147+Qingzi-Lan@users.noreply.github.com>
Co-authored-by: Payton Staub <staubhpa@gmail.com>
Co-authored-by: Payton Staub <pstaub@amazon.com>
Co-authored-by: Shreya Pandit <shreya.pandit25@gmail.com>
Co-authored-by: Ahsan Khan <ahsan.al.zaki@gmail.com>
Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mufaddal-rohawala mufaddal-rohawala mufaddal-rohawala approved these changes
+1 more reviewer
@navinsoni navinsoni navinsoni approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@ahsan-z-khan @sagemaker-bot @navinsoni @mufaddal-rohawala @jeniyat @qidewenwhen @Qingzi-Lan @staubhp