change: update code to get commit_id in codepipeline by navinsoni · Pull Request #2961 · aws/sagemaker-python-sdk

navinsoni · 2022-02-26T01:12:34Z

Issue #, if available:

Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2022-02-26T01:28:39Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: e572b07
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2022-02-26T01:29:24Z

Codecov Report

Merging #2961 (e572b07) into dev (6670e30) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #2961   +/-   ##
=======================================
  Coverage   89.81%   89.81%           
=======================================
  Files         196      196           
  Lines       16548    16548           
=======================================
  Hits        14863    14863           
  Misses       1685     1685

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6670e30...e572b07. Read the comment docs.

sagemaker-bot · 2022-02-26T01:38:08Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: e572b07
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-26T01:42:33Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: e572b07
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

* change: update code to get commit_id in codepipeline (#2961) * feature: Data Serializer (#2956) * change: reorganize test files for workflow (#2960) Co-authored-by: Ben Crabtree <bencrab@amazon.com> Co-authored-by: Navin Soni <navinsoni89@gmail.com> Co-authored-by: Jeniya Tabassum <jeniya.tabassum@gmail.com> Co-authored-by: Dewen Qi <qidewen@amazon.com> * feature: TensorFlow 2.4 for Neo (#2861) Co-authored-by: Ben Crabtree <bencrab@amazon.com> Co-authored-by: Navin Soni <navinsoni89@gmail.com> Co-authored-by: Jeniya Tabassum <jeniya.tabassum@gmail.com> * fix: Remove sagemaker_job_name from hyperparameters in TrainingStep (#2950) Co-authored-by: Payton Staub <pstaub@amazon.com> * fix: Style update in DataSerializer (#2962) * documentation: smddp doc update (#2968) * fix: container env generation for S3 URI and add test for the same (#2971) * documentation: update sagemaker training compiler docstring (#2969) * feat: Python 3.9 for readthedocs (#2973) Co-authored-by: Ben Crabtree <bencrab@amazon.com> Co-authored-by: Navin Soni <navinsoni89@gmail.com> Co-authored-by: Jeniya Tabassum <jeniya.tabassum@gmail.com> Co-authored-by: Dewen Qi <qidewen@amazon.com> Co-authored-by: Payton Staub <pstaub@amazon.com> Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com> Co-authored-by: Qingzi-Lan <83724147+Qingzi-Lan@users.noreply.github.com> Co-authored-by: Payton Staub <staubhpa@gmail.com> * fix doc structure * archive 1.6.0 doc * add new args, refs, and links * fix version number * incorp eng feedback, update docstrings, improve xref * Trigger Build * minor fix, trigger build again * fix typo Co-authored-by: Navin Soni <navinsoni89@gmail.com> Co-authored-by: Jeniya Tabassum <jeniya.tabassum@gmail.com> Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com> Co-authored-by: Ben Crabtree <bencrab@amazon.com> Co-authored-by: Dewen Qi <qidewen@amazon.com> Co-authored-by: Qingzi-Lan <83724147+Qingzi-Lan@users.noreply.github.com> Co-authored-by: Payton Staub <staubhpa@gmail.com> Co-authored-by: Payton Staub <pstaub@amazon.com> Co-authored-by: Shreya Pandit <shreya.pandit25@gmail.com> Co-authored-by: Ahsan Khan <ahsan.al.zaki@gmail.com> Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>

* change: update code to get commit_id in codepipeline (aws#2961) * feature: Data Serializer (aws#2956) * change: reorganize test files for workflow (aws#2960) Co-authored-by: Ben Crabtree <bencrab@amazon.com> Co-authored-by: Navin Soni <navinsoni89@gmail.com> Co-authored-by: Jeniya Tabassum <jeniya.tabassum@gmail.com> Co-authored-by: Dewen Qi <qidewen@amazon.com> * feature: TensorFlow 2.4 for Neo (aws#2861) Co-authored-by: Ben Crabtree <bencrab@amazon.com> Co-authored-by: Navin Soni <navinsoni89@gmail.com> Co-authored-by: Jeniya Tabassum <jeniya.tabassum@gmail.com> * fix: Remove sagemaker_job_name from hyperparameters in TrainingStep (aws#2950) Co-authored-by: Payton Staub <pstaub@amazon.com> * fix: Style update in DataSerializer (aws#2962) * documentation: smddp doc update (aws#2968) * fix: container env generation for S3 URI and add test for the same (aws#2971) * documentation: update sagemaker training compiler docstring (aws#2969) * feat: Python 3.9 for readthedocs (aws#2973) Co-authored-by: Ben Crabtree <bencrab@amazon.com> Co-authored-by: Navin Soni <navinsoni89@gmail.com> Co-authored-by: Jeniya Tabassum <jeniya.tabassum@gmail.com> Co-authored-by: Dewen Qi <qidewen@amazon.com> Co-authored-by: Payton Staub <pstaub@amazon.com> Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com> Co-authored-by: Qingzi-Lan <83724147+Qingzi-Lan@users.noreply.github.com> Co-authored-by: Payton Staub <staubhpa@gmail.com> * fix doc structure * archive 1.6.0 doc * add new args, refs, and links * fix version number * incorp eng feedback, update docstrings, improve xref * Trigger Build * minor fix, trigger build again * fix typo Co-authored-by: Navin Soni <navinsoni89@gmail.com> Co-authored-by: Jeniya Tabassum <jeniya.tabassum@gmail.com> Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com> Co-authored-by: Ben Crabtree <bencrab@amazon.com> Co-authored-by: Dewen Qi <qidewen@amazon.com> Co-authored-by: Qingzi-Lan <83724147+Qingzi-Lan@users.noreply.github.com> Co-authored-by: Payton Staub <staubhpa@gmail.com> Co-authored-by: Payton Staub <pstaub@amazon.com> Co-authored-by: Shreya Pandit <shreya.pandit25@gmail.com> Co-authored-by: Ahsan Khan <ahsan.al.zaki@gmail.com> Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com>

change: update code to get commit_id in codepipeline

e572b07

navinsoni requested a review from shreyapandit February 26, 2022 01:13

BasilBeirouti approved these changes Feb 26, 2022

View reviewed changes

shreyapandit approved these changes Feb 26, 2022

View reviewed changes

navinsoni merged commit 4ce6623 into aws:dev Feb 26, 2022

shreyapandit pushed a commit that referenced this pull request Mar 1, 2022

change: update code to get commit_id in codepipeline (#2961)

f166b60

shreyapandit pushed a commit that referenced this pull request Mar 4, 2022

change: update code to get commit_id in codepipeline (#2961)

4883b2e

jerrypeng7773 pushed a commit to jerrypeng7773/sagemaker-python-sdk that referenced this pull request Apr 19, 2022

change: update code to get commit_id in codepipeline (aws#2961)

8fb0b3d

Evan-W-ang added a commit to Evan-W-ang/sagemaker-python-sdk that referenced this pull request Jun 8, 2026

change: update code to get commit_id in codepipeline (aws#2961)

d2599a3

Navigation Menu

Uh oh!

change: update code to get commit_id in codepipeline - #2961

change: update code to get commit_id in codepipeline#2961
navinsoni merged 1 commit into
aws:devfrom
navinsoni:dev

navinsoni commented Feb 26, 2022

Uh oh!

sagemaker-bot commented Feb 26, 2022

Uh oh!

codecov-commenter commented Feb 26, 2022 •

edited

Loading

Uh oh!

sagemaker-bot commented Feb 26, 2022

Uh oh!

sagemaker-bot commented Feb 26, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

navinsoni commented Feb 26, 2022

Merge Checklist

General

Tests

Uh oh!

sagemaker-bot commented Feb 26, 2022

AWS CodeBuild CI Report

Uh oh!

codecov-commenter commented Feb 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sagemaker-bot commented Feb 26, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 26, 2022

AWS CodeBuild CI Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov-commenter commented Feb 26, 2022 •

edited

Loading