Skip to content
This repository was archived by the owner on Feb 19, 2020. It is now read-only.

fix file_exists #38

Closed
dhensen wants to merge 2 commits into from
Closed

fix file_exists #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b1c7be7
Fix file_exists method for filenames that contain subdirectories by j…
dhensen Nov 15, 2017
e8fd800
Fixed unicode keyword for python3
dhensen Nov 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions src/codacy/reporter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,13 +47,7 @@ def get_git_directory():


def file_exists(rootdir, filename):
for root, subFolders, files in os.walk(rootdir):
if filename in files:
return True
else:
for subFolder in subFolders:
return file_exists(os.path.join(rootdir, subFolder), filename)
return False
return os.path.exists(os.path.join(rootdir, filename))


def generate_filename(sources, filename, git_directory):
Expand Down
10 changes: 9 additions & 1 deletion tests/tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,19 @@
import json
import os
import unittest
import sys

import codacy.reporter

HERE = os.path.abspath(os.path.dirname(__file__))

print("PYTHON_VERSION: ", sys.version_info)

if sys.version_info[0] == 3:
unicode_type = str
else:
unicode_type = unicode


def _file_location(*args):
return os.path.join(HERE, *args)
Expand All @@ -22,7 +30,7 @@ def to_utf8(d):
result = {}
for key, value in d.items():
result[to_utf8(key)] = to_utf8(value)
elif type(d) is unicode:
elif type(d) is unicode_type:
return d.encode('utf8')
else:
return d
Expand Down