Skip to content
This repository was archived by the owner on Feb 19, 2020. It is now read-only.

fix file_exists#38

Closed
dhensen wants to merge 2 commits intoarchived-codacy:masterfrom
dhensen:master
Closed

fix file_exists#38
dhensen wants to merge 2 commits intoarchived-codacy:masterfrom
dhensen:master

Conversation

@dhensen
Copy link
Copy Markdown

@dhensen dhensen commented Nov 15, 2017

When having a filename=foo/bar/baz it would never be matched in files produced by os.walk.

I just used os.path.exists, tests pass.

There is a an issue with py350 in tox config though.

@IceflowRE
Copy link
Copy Markdown

See #36

@dhensen
Copy link
Copy Markdown
Author

dhensen commented Nov 15, 2017

@IceflowRE Wow I fixed the same thing 😲
I've been wanting to fix this for a while, but did not have time. I did not check outstanding PR's before starting this an hour ago. What a coincidence that 2 people fix the same thing on the same day... your PR covers more stuff though, good work 👍

@dhensen
Copy link
Copy Markdown
Author

dhensen commented Nov 15, 2017

@IceflowRE did you run tests locally? What python version do you have? I ask this because I had issues with the unicode keyword not being in python3.

@IceflowRE
Copy link
Copy Markdown

IceflowRE commented Nov 15, 2017

I run tests with nose2 so i cant say much about tox. And no i run the tests via CI and only for python 3.6/(3.7), since i need the latest features of python ^^

@dhensen
Copy link
Copy Markdown
Author

dhensen commented Nov 15, 2017

Good to know. I guess then there is more going on on that CI server, because locally I could in no way make tests pass without that unicode keyword fix. I run python 3.6.3 to be exact.

@rtfpessoa
Copy link
Copy Markdown

Sorry for the delay. Fixed by #36. Let me know if I missed something.

@rtfpessoa rtfpessoa closed this Dec 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants