Skip to content

6.0 release: Angular 7 - #1922

Closed
jamesdaniels wants to merge 2 commits into
masterfrom
ng7
Closed

6.0 release: Angular 7#1922
jamesdaniels wants to merge 2 commits into
masterfrom
ng7

Conversation

@jamesdaniels

@jamesdaniels jamesdaniels commented Oct 19, 2018

Copy link
Copy Markdown
Contributor

Checklist

  • Issue number for this PR: #nnn (required)
  • Docs included?: (yes/no; required for all API/functional changes)
  • Test units included?: (yes/no; required)
  • In a clean directory, yarn install, yarn test run successfully? (yes/no; required)

Description

Code sample

@jamesdaniels jamesdaniels self-assigned this Oct 19, 2018
@jamesdaniels jamesdaniels changed the title Release 6.0: Depend on Angular 7 6.0 release: Angular 7 Oct 19, 2018
@jamesdaniels jamesdaniels mentioned this pull request Oct 19, 2018
Closed
Splaktar
Splaktar reviewed Oct 19, 2018
View reviewed changes

@Splaktar Splaktar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason that this version can't support Angular >=6.0.0 <8 and TypeScript >=2.7.2 <3.2?

Since there aren't really any breaking changes, it seems like it should still work fine with v6.

@jamesdaniels

jamesdaniels commented Oct 19, 2018

Copy link
Copy Markdown
Contributor Author

@Splaktar fair, I was expecting breaks TBH. I may back port those to the 5.1 release and kill this.

@jamesdaniels

jamesdaniels commented Oct 19, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Closing in favor of ed92c45 #1920, thanks for the sanity check @Splaktar

@jamesdaniels
jamesdaniels deleted the ng7 branch October 19, 2018 01:26
@rcanu

rcanu commented Oct 19, 2018

Copy link
Copy Markdown

Seems to be working fine too when I upgraded to Angular 7. Although this prompts when doing npm install

npm WARN @angular/fire@5.0.2 requires a peer of @angular/common@^6.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN @angular/fire@5.0.2 requires a peer of @angular/core@^6.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN @angular/fire@5.0.2 requires a peer of @angular/platform-browser@^6.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN @angular/fire@5.0.2 requires a peer of @angular/platform-browser-dynamic@^6.0.0 but none is installed. You must install peer dependencies yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davideast davideast Awaiting requested review from davideast
1 more reviewer
@Splaktar Splaktar Splaktar left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@jamesdaniels jamesdaniels

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jamesdaniels @rcanu @Splaktar @googlebot