5.1 release: support Firebase 5.5, multi-tab sync, function region selection, and Angular 7 - #1920
Merged
Conversation
jamesdaniels
commented
Oct 17, 2018
| * Attempt to enable persistent storage, if possible | ||
| */ | ||
| static enablePersistence(): ModuleWithProviders { | ||
| static enablePersistence(persistenceSettings?: firestore.PersistenceSettings): ModuleWithProviders { |
Contributor
Author
There was a problem hiding this comment.
Use PersistenceSettings from ./interface
|
Waiting for this |
Closed
Splaktar
reviewed
Oct 19, 2018
| "systemjs-builder": "^0.15.7", | ||
| "traceur": "0.0.96", | ||
| "typescript": ">=2.7.2 <2.8.0" | ||
| "typescript": ">=2.7.2 <2.8.0, >=3.1.1 <3.2" |
Contributor
There was a problem hiding this comment.
Are there problems with supporting TypeScript 2.8.0, 2.9.2, 3.0.0,, 3.1.0 etc?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
yarn install,yarn testrun successfully? yesDescription
enablePersistencefactory method or via thePersistenceSettingsTokeninjection token.firebase/appis less broken, pull in many of the types from there.FunctionsRegionTokenInjection TokenCode sample