Skip to content

fix(core): cancel in-progress request when same value is assigned #59280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
crisbeto wants to merge 1 commit into from
Closed

fix(core): cancel in-progress request when same value is assigned #59280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/core/src/resource/resource.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,11 @@ class ResourceImpl<T, R> extends BaseWritableResource<T> implements ResourceRef<
}

const current = untracked(this.value);
if (this.equal ? this.equal(current, value) : current === value) {

if (
untracked(this.status) === ResourceStatus.Local &&
(this.equal ? this.equal(current, value) : current === value)
) {
return;
}

Expand Down
53 changes: 53 additions & 0 deletions packages/core/test/resource/resource_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -622,6 +622,59 @@ describe('resource', () => {
stream.set({error: 'fail'});
expect(res.value()).toBe(undefined);
});

it('should interrupt pending request if the same value is set', async () => {
const counter = signal(0);
const backend = new MockEchoBackend<{counter: number} | null>();
const aborted: ({counter: number} | null)[] = [];
const echoResource = resource<{counter: number} | null, {counter: number} | null>({
request: () => ({counter: counter()}),
loader: ({request, abortSignal}) => {
abortSignal.addEventListener('abort', () => backend.abort(request));
return backend.fetch(request).catch((reason) => {
if (reason === 'aborted') {
aborted.push(request);
}
throw new Error(reason);
});
},
injector: TestBed.inject(Injector),
});

// Start the initial load.
TestBed.flushEffects();
await Promise.resolve();
expect(echoResource.status()).toBe(ResourceStatus.Loading);
expect(echoResource.value()).toBe(undefined);
expect(echoResource.error()).toBe(undefined);
expect(aborted).toEqual([]);

// Interrupt by setting a value before the request has resolved.
echoResource.set(null);
TestBed.flushEffects();
await backend.flush();
expect(echoResource.status()).toBe(ResourceStatus.Local);
expect(echoResource.value()).toBe(null);
expect(echoResource.error()).toBe(undefined);
expect(aborted).toEqual([{counter: 0}]);

// Reload the resource to trigger another request.
echoResource.reload();
TestBed.flushEffects();
await Promise.resolve();
expect(echoResource.status()).toBe(ResourceStatus.Reloading);
expect(echoResource.value()).toBe(null);
expect(echoResource.error()).toBe(undefined);
expect(aborted).toEqual([{counter: 0}]);

// Interrupt the reload with the same value as before.
echoResource.set(null);
await backend.flush();
expect(echoResource.status()).toBe(ResourceStatus.Local);
expect(echoResource.value()).toBe(null);
expect(echoResource.error()).toBe(undefined);
expect(aborted).toEqual([{counter: 0}, {counter: 0}]);
});
});

function flushMicrotasks(): Promise<void> {
Expand Down