fix(core): cancel in-progress request when same value is assigned - #59280
Closed
crisbeto wants to merge 1 commit into
Closed
fix(core): cancel in-progress request when same value is assigned#59280crisbeto wants to merge 1 commit into
crisbeto wants to merge 1 commit into
Conversation
crisbeto
marked this pull request as ready for review
December 22, 2024 08:22
Member
|
Hey @crisbeto, can you rebase this before I take a look? I want to make sure I'm reviewing after the most recent resource changes. |
crisbeto
force-pushed
the
59272/resource-same-value
branch
3 times, most recently
from
January 28, 2025 20:47
2fd2f3e to
ebccd26
Compare
alxhub
approved these changes
Jan 28, 2025
Fixes that `resource` wasn't cancelling its in-progress request if the same value as the current one is assigned. Fixes angular#59272.
crisbeto
force-pushed
the
59272/resource-same-value
branch
from
January 28, 2025 20:54
ebccd26 to
1f07f71
Compare
Member
|
This PR was merged into the repository by commit 96e602e. The changes were merged into the following branches: main |
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
…gular#59280) Fixes that `resource` wasn't cancelling its in-progress request if the same value as the current one is assigned. Fixes angular#59272. PR Close angular#59280
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes that
resourcewasn't cancelling its in-progress request if the same value as the current one is assigned.Fixes #59272.