feat: Add optional entity operator wait skip for Kind #397
Conversation
Add SKIP_ENTITY_OPERATOR_WAIT environment variable to work around entity operator timeout issues in some environments (Linux + Podman). When set to 'true': - Checks only Kafka broker pod readiness (not full Kafka resource) - Polls Kafka broker directly to verify topic creation This is an opt-in workaround that doesn't affect standard deployments. Also improves user messaging: - Added timeout information (10 minutes) - Added proactive hints about workaround if timeout occurs - Set expectations for topic creation timing
Summary of ChangesHello @kabir, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces an optional workaround for Kafka entity operator timeout issues that can occur in specific environments, particularly when using Kind with Podman on Linux. By setting a new environment variable, users can opt to skip the full entity operator readiness checks, allowing the deployment to proceed by verifying only the core Kafka broker and directly confirming topic creation. This change also significantly improves user experience by providing better guidance and troubleshooting tips within the deployment process and documentation. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a valuable workaround for Kafka entity operator timeouts in certain environments by adding the SKIP_ENTITY_OPERATOR_WAIT flag. The changes are well-implemented in the deployment script and clearly documented in the README. My review includes one suggestion to improve the error handling in the deployment script for a better user experience when timeouts occur.
Add SKIP_ENTITY_OPERATOR_WAIT environment variable to work around entity operator timeout issues in some environments (Linux + Podman). When set to 'true': - Checks only Kafka broker pod readiness (not full Kafka resource) - Polls Kafka broker directly to verify topic creation This is an opt-in workaround that doesn't affect standard deployments. Also improves user messaging: - Added timeout information (10 minutes) - Added proactive hints about workaround if timeout occurs - Set expectations for topic creation timing
Add SKIP_ENTITY_OPERATOR_WAIT environment variable to work around entity operator timeout issues in some environments (Linux + Podman).
When set to 'true':
This is an opt-in workaround that doesn't affect standard deployments.
Also improves user messaging: