feat: Migrate cloud deployment example from Kind to Minikube #393
Conversation
Summary of ChangesHello @kabir, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the cloud deployment example to use Minikube instead of Kind, primarily to enhance stability and improve compatibility across different container runtimes like Docker and Podman. The changes aim to provide a more reliable and consistent local Kubernetes development experience, especially for users leveraging Podman. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request migrates the cloud deployment example from Kind to Minikube, addressing stability issues, especially with Podman. It adds support for both Docker and Podman container runtimes. The changes include migrating from Kind to Minikube with NodePort, using tarball + minikube image load for Podman, using Minikube registry addon with port-forwarding for Docker, and handling rootless mode with containerd runtime for Linux + Podman. The code changes primarily involve updating the README.md file, the agent deployment YAML file, and the deploy and cleanup scripts to reflect the switch to Minikube and the different handling of Docker and Podman.
Replaces Kind with Minikube due to stability issues, especially with Podman. Adds support for both Docker and Podman container runtimes. Changes: - Migrate from Kind to Minikube with NodePort (port 30080) - Podman: Use tarball + minikube image load (no registry needed) - Docker: Use Minikube registry addon with port-forwarding - Linux + Podman: Rootless mode with containerd runtime - Linux + Podman: Check broker pod directly (entity operator compatibility issues) - Linux + Podman: Poll Kafka broker until topic exists before deploying agents - Mac/Linux + Podman: Background service tunnel for NodePort access - Dynamic image references and imagePullPolicy based on container tool Tested on: - macOS with Podman ✓ - Linux (Fedora) with Podman ✓ - Linux (GitHub Actions) with Docker ✓
81e01e7 to
333111a
Compare
|
We decided not to switch to Minikube since the differences between what you need to do on Podman and Docker is quite big. Since a lot of us use Podman locally, and GH Actions uses Docker, the difference is too big. |
Replaces Kind with Minikube due to stability issues, especially with Podman.
Adds support for both Docker and Podman container runtimes.
Changes:
Tested on:
The original work was done in #389