Fix unused assignments - #8836
Merged
Merged
Conversation
DNin01
marked this pull request as ready for review
February 11, 2026 19:57
Member
|
It might be a good idea to pin the ESLint version to 10.x and update it on our own schedule. |
DNin01
commented
Feb 11, 2026
Merged
mxmou
reviewed
Feb 18, 2026
Hans5958
removed their request for review
February 18, 2026 15:00
mxmou
previously approved these changes
Feb 19, 2026
DNin01
commented
Feb 19, 2026
mxmou
approved these changes
Feb 22, 2026
Member
Author
|
No opinions on the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The ESLint rule
no-useless-assignmentrecently became recommended and is now checked for in our repository. As a result, some code now creates error messages. These errors happen when a variable is assigned a value that is never read later or is guaranteed to be reassigned before it is read.You can learn more about this on the ESLint Docs.
Changes
These errors were fixed. In the process, a bug in
editor-theme3where the addon always use the old Blockly reference forFieldNotewas fixed. The 10 other changes should have no effect.Since opening this PR, ESLint was pinned to version 9.x, so this PR explicitly enables the rule that is recommended on v10.
Tests
ESLint checks succeed on the changes.
Webpages tested in Edge 145.