Skip to content

editor-theme3, number-pad: new Blockly - #7922

Merged
mxmou merged 2 commits into
ScratchAddons:masterfrom
mxmou:modern-blockly-theme3
Nov 18, 2024
Merged

editor-theme3, number-pad: new Blockly#7922
mxmou merged 2 commits into
ScratchAddons:masterfrom
mxmou:modern-blockly-theme3

Conversation

@mxmou

@mxmou mxmou commented Nov 8, 2024

Copy link
Copy Markdown
Member

Changes

Updates "customizable block colors" and "always show number pad" to work with the new version of Blockly.

Tests

Tested both Scratch versions on Edge and Firefox.

@mxmou mxmou added scope: addon Related to one or multiple addons scope: upstream Related to something we depend on (like Scratch, a library, or the browser) labels Nov 8, 2024
@mxmou mxmou self-assigned this Nov 8, 2024
@Samq64

Samq64 commented Nov 17, 2024

Copy link
Copy Markdown
Member

Hat blocks become flat after dynamically changing theme3's settings and dragging the block.
screenshot-2024-11-17-21-18-28

@Samq64

Samq64 commented Nov 17, 2024

Copy link
Copy Markdown
Member

Resolves #5886
Closes #7781

@mxmou
mxmou requested a review from Samq64 November 18, 2024 11:46
@Samq64

Samq64 commented Nov 18, 2024

Copy link
Copy Markdown
Member

The dial is inconsistent between Scratch versions with some settings. I made sure Scratch's high contrast mode was off before enabling the addon.

On the Scratch website:
screenshot-2024-11-18-12-54-45screenshot-2024-11-18-13-04-14

And on new Blockly:
screenshot-2024-11-18-12-54-55screenshot-2024-11-18-13-04-35

@mxmou

mxmou commented Nov 18, 2024

Copy link
Copy Markdown
Member Author

The dial is inconsistent between Scratch versions with some settings. I made sure Scratch's high contrast mode was off before enabling the addon.

On the current version of Scratch, the dial isn't affected by Scratch's high contrast mode and the addon doesn't change it either. This was changed in the new version and I think the way it looks with the addon is correct - the high contrast preset, for example, is identical to Scratch's high contrast mode:
image

@Samq64 Samq64 added the status: needs review PR needs 1 more approval label Nov 18, 2024
@WorldLanguages WorldLanguages removed the status: needs review PR needs 1 more approval label Nov 18, 2024
@mxmou
mxmou merged commit 6d93eda into ScratchAddons:master Nov 18, 2024
@mxmou
mxmou deleted the modern-blockly-theme3 branch November 18, 2024 19:26
Comment thread addons/editor-theme3/theme3.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: addon Related to one or multiple addons scope: upstream Related to something we depend on (like Scratch, a library, or the browser)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants