Rename some addons - #6582
Conversation
|
I just noticed this unintentionally reverts a lot of #2799. |
DNin01
left a comment
There was a problem hiding this comment.
After a quick look, I have some things to say...
|
bitmap-copy should stay a noun |
|
"Reverse project controls order" should be "Reverse project control order" |
|
For editor-messages I can suggest "Message icon in editor" |
|
also why can't I review? |
@Secret-chest Go to the Files changed tab, hover over a line and click |
I think we’re trying to stay away from unnecessarily using “button” or “icon” and things like that. |
I think “controls” makes more sense because there are multiple different controls on the row. |
Sorry, I'm using OctoDroid and it says review creation failed |
Co-authored-by: DNin01 <106490990+DNin01@users.noreply.github.com>
Co-authored-by: DNin01 <106490990+DNin01@users.noreply.github.com>
|
At first I thought this was a great idea and changed a bunch more names which is partly why the description is confusing. But I realized half of them weren't really any better than the current ones. |
That's why PRs are reviewed 🤷 |
|
@BroJac5246 @Samq64 consistency is more important, don't change names to phrases just because it removes one letter |
Yeah, always consider the discussion from previous PRs like that one you linked. |
Co-Authored-By: DNin01 <106490990+DNin01@users.noreply.github.com>
|
Should I just revert the last two that can't be agreed on? |
|
Did you mean to close this? |
Yes, but I'll re-open it and just revert the last couple that can't be agreed on. |
Co-authored-by: DNin01 <106490990+DNin01@users.noreply.github.com>
Co-authored-by: DNin01 <106490990+DNin01@users.noreply.github.com>
Co-authored-by: DNin01 <106490990+DNin01@users.noreply.github.com>
There was a problem hiding this comment.
Renames a bunch of addons to try to make them shorter and less like short descriptions.
Addons aren't products, they're toggles on a settings page. Their names should be descriptive enough that the user doesn't have to read the full description to get at least a basic idea of what the addon is for. They should also be short, but clarity is more important than shortening the name by a few characters.
I think the following changes proposed by this PR are unnecessary or even worse than the current names:
- Color picker number inputs, Comment line breaks, Reverse project control order, Editor unshare button (I think the current names are easier to understand)
- Forum post code copier ("forum post code" could mean the post's BBCode source)
- Name backpacked scripts (the current name indicates that scripts that are already in the backpack can't be renamed, which is important to know)
- Prevent spacing overlapping scripts (not clear that it prevents Scratch - not the user - from doing someting)
- Costume editor stage eyedropper (the addon doesn't add a "stage eyedropper", it changes the existing eyedropper)
"Name scripts before backpacking"? |
Co-Authored-By: Maximouse <51849865+mxmou@users.noreply.github.com>
I have opinions on this, which I have put on #2764 instead. #2764 (comment) |
Changes
Renames a bunch of addons to try to make them shorter and less like short descriptions.
Reason for changes
Addon names should be as short as possible while still being easy to understand.
Related: