Fix grammar and wording by cobaltt7 · Pull Request #4325 · ScratchAddons/ScratchAddons

cobaltt7 · 2022-02-24T04:23:46Z

also some stuff for consistency and remove opinionated stuff

Signed-off-by: RedGuy12 <paul@reid-family.org>

Hans5958 · 2022-02-24T07:57:55Z

-Scratch Addons is a WebExtension (supports both Chrome and Firefox). Scratch Addons' mission is to combine all existing Scratch extensions, userscripts and userstyles into a single easy-to-access place, while still letting users choose which ones to enable.
+Scratch Addons is a WebExtension supporting both Chrome and Firefox. Scratch Addons' mission is to combine all existing Scratch extensions, userscripts, and userstyles into a single easy-to-access place, while still letting users choose which ones to enable.

 ### What's actually an "addon"?

-An addon is similar to an extension or a userscript, but they use special APIs provided by the Scratch Addons extension. These APIs allow addons to run scripts on a Scratch page (userscripts), run scripts on the background (persistent scripts), or apply styles to the Scratch website (userstyles).
+An addon is similar to an extension or a userscript, but they use special APIs provided by the Scratch Addons extension. These APIs allow addons to run scripts on a Scratch page (userscripts) or apply styles to the Scratch website (userstyles).

-Userscripts and persistent scripts can use the `addon.*` JavaScript APIs, which allow them to obtain Scratch-related information (for example, get the current logged in user) and also use extension APIs (like sending notifications).
+Userscripts can use the `addon.*` JavaScript APIs, which allow them to obtain Scratch-related information (for example, get the currently logged-in user) and also use extension APIs (like sending notifications).


Don't forget to update FAQ

FAQ has an open pr to make it less techy

We should move this somewhere. The README is too long with it. The reason I put it on FAQ is so later we can remove it from the README.

it's fine imo. there are many readmes that are way longer

Those long README are those that don't have wiki or other types of documentation (see youtube-dl). We have exaustive amount of documentation but we put it on the README. If README can go simpler than I rather.

The README could be also used for advertisement like the website.

apple502j · 2022-02-24T08:37:25Z

 {
-  "name": "Better emojis",
-  "description": "Replaces the emojis in comments on the website with improved vector designs.",
+  "name": "Vectorized emojis",


Should not be changed

"Better" is very opinionated.

"Vectorize" is not a word people use often.

Vector emojis?

HQ/HD emojis

"Vector" is too technical. "HD emojis" or "High quality emojis" sound better.

"High quality" would suggest that the design of the emojis isn't changed.

so what do i do? for this and for material-forum-editor-buttons

I think something like "Alternative emoji design" could be used for this one (and "alternative icons in forum post editor" for material-editor-buttons).

apple502j · 2022-02-24T08:40:17Z

 {
-  "name": "Grab single block with Ctrl key",
-  "description": "Adds the ability to drag a single block out of the middle of a script (instead of the entire stack attached below it) while holding the Ctrl key.",
+  "name": "Single block grab",


"grabbing"?

but then its a verb

Single block grabbing is a noun phrase?

apple502j · 2022-02-24T08:59:15Z

-  "name": "Enhanced full screen",
-  "description": "Fixes some undesired effects in the project player's full screen mode, opens it in your browser's full screen mode, and hides the green flag toolbar.",
+  "name": "Browse-native full screen",
+  "description": "Fixes some undesired effects in the project player's full screen mode, opens it in your browser's full screen mode, and/or hides the green flag toolbar.",


Don't use and/or

apple502j · 2022-02-24T09:01:52Z

 {
  "name": "ocular integration",
-  "description": "Shows ocular statuses and forum post reactions. Uses my-ocular.jeffalo.net to obtain data.",
+  "description": "Shows ocular statuses and forum post reactions.",


Suggested change

"description": "Shows ocular statuses and forum post reactions.",

"description": "Shows ocular statuses and forum post reactions. Uses my-ocular.jeffalo.net to obtain data.",

apple502j · 2022-02-24T09:02:50Z

 {
  "name": "Profile statistics",
-  "description": "Shows statistics from ScratchDB on user profiles.",
+  "description": "Shows statistics on user profiles.",


Suggested change

"description": "Shows statistics on user profiles.",

"description": "Shows statistics from ScratchDB on user profiles.",

Probably because he added it on the credits? I don't know, but it's better to expose it better.

apple502j · 2022-02-24T09:06:15Z

"Gramamar" LMAO

Signed-off-by: RedGuy12 <paul@reid-family.org>

…nto grammar

Hans5958 · 2022-02-25T05:25:13Z

-  "name": "Hide Tutorials button",
-  "description": "Hides the Tutorials button in the editor menu bar.",
+  "name": "Hidden \"Tutorials\" button",
+  "description": "Hides the \"Tutorials\" button from the editor menu bar.",


Seems counterintuitive because in hindsight, it could imply something it just adds a hidden button (and we think like, why?), and not hide the button itself.

This also applies to other "hide XYZ" addons.

Hans5958 · 2022-02-25T05:26:47Z

-  "name": "More links",
-  "description": "Adds links for URLs pointing outside scratch.mit.edu.",
+  "name": "More clickable links",
+  "description": "Makes URLs pointing outside scratch.mit.edu clickable.",


I suppose links are clickable in the first place?

Yeah, "clickable" part is redundant.

mxmou

Descriptions of addons that allow something to be customized should probably begin with "allows you to change" and not "changes".

mxmou · 2022-02-25T07:25:22Z

  },
  "scratchAddonsThemeDescription": {
-    "message": "This allows you to switch between light and dark themes for this settings page, and the extension's popup."
+    "message": "This allows you to switch between light and dark themes for this settings page and the extension's popup."


Could "extension popup" be used instead for consistency?

mxmou · 2022-02-25T07:38:28Z

 {
  "name": "Profile page banner",
-  "description": "Turns the featured project on any user's profile into a nice-looking banner.",
+  "description": "Turns the featured project on any user's profile into a larger banner.",


"Wider" would be more accurate.

mxmou · 2022-02-25T07:40:29Z

-  "name": "Better forum quoter",
-  "description": "Select text in a forum post and click quote in the bottom right corner to only quote the select text.",
+  "name": "Partial forum post quoter",
+  "description": "Allows you to only quote text you have selected when you press \"quote\", if there is text selected.",


Is "if there is text selected" necessary?

Unnecessary IMO, it's obvious that you can't quote selected text if you select nothing.

i went back on forth on this one, i didn't want it to sound like you can't quote anything without text selected

I don't think it would sound like that. We don't remove features unless it explicitly says so.

mxmou · 2022-02-25T07:44:43Z

    {
      "type": "notice",
-      "text": "On macOS, use the Option key instead of the Alt key and Command key instead of the Control key.",
+      "text": "On macOS, use the \"Option\" key instead of the \"Alt\" key and \"Command\" key instead of the \"Ctrl\" key.",


Suggested change

"text": "On macOS, use the \"Option\" key instead of the \"Alt\" key and \"Command\" key instead of the \"Ctrl\" key.",

"text": "On macOS, use the \"Option\" key instead of the \"Alt\" key and \"Cmd\" key instead of the \"Ctrl\" key.",

mxmou · 2022-02-25T07:46:30Z

 {
  "name": "Save blocks as image",
-  "description": "Right click the code area to export blocks as SVG/PNG images.",
+  "description": "Adds options to right-click menus to export blocks as SVG/PNG images.",


Suggested change

"description": "Adds options to right-click menus to export blocks as SVG/PNG images.",

"description": "Adds options to the code area right-click menu to export blocks as SVG/PNG images.",

mxmou · 2022-02-25T08:12:47Z

-  "name": "Old studio layout",
-  "description": "Reverts the layout of the studio page back to the one used before the studio update or the one previously available as part of the Scratch 2.0 \u2192 3.0 addon.",
+  "name": "2.0 studio layout",
+  "description": "Reverts the layout of the studio page to look like Scratch 2.0 or how it looked using the \"Scratch 2.0 \u2192 3.0\" addon.",


Don't use "Scratch 2.0" to refer to 2.0-styled (scratchr2) pages.

mxmou · 2022-02-25T08:13:40Z

 {
-  "name": "Paint costume by default",
-  "description": "Changes the default action of \"Choose a Sprite/Costume/Backdrop/Sound\" buttons, which open the library by default.",
+  "name": "\"Paint costume\" by default",


"Paint costume" is not the name of any Scratch feature, so it doesn't need quotes.

mxmou · 2022-02-25T08:14:55Z

 {
  "name": "Scratch Notifier",
-  "description": "Notifications on new Scratch messages. Click the notification to go straight to the message (comment, project, etc.)",
+  "description": "Receive notifications when you get new Scratch messages. Click the notification to go straight to the message (comment, project, etc.)",


You removed imperative from a lot of other addon descriptions - is it really appropriate here?

mxmou · 2022-02-25T08:18:28Z

-  "name": "YouTube full screen",
-  "description": "Enables the full screen button in Scratch's YouTube video player.",
+  "name": "YouTube fullscreen",
+  "description": "Enables the fullscreen button in Scratch's YouTube video player.",


mxmou · 2022-02-25T08:18:58Z

  "name": "True forums YouTube links",
-  "description": "Replaces links to the embedded site with real YouTube links.",
+  "description": "Replaces links to Scratch's YouTube embed page with real YouTube links.",


Should be consistent with youtube-fullscreen.

mxmou · 2022-02-25T08:21:37Z

If we're changing capitalization and quotes, could #2799 (comment) be addressed fully?

apple502j

Schema validation failures, word changes, and credit fixes (should not have prepositions)

apple502j · 2022-02-25T08:14:28Z

 {
-  "name": "Do not shift pasted items",
-  "description": "Paste copied items at their original position instead of shifted slightly in the costume editor.",
+  "name": "Unshifted pasted items",


Old name is better; the addon does not "unshift", it just prevents it from shifting. (Same way people don't say "uneaten cake".)

How about "No shift" haha

apple502j · 2022-02-25T08:17:47Z

 {
  "name": "Extra key support",
-  "description": "Adds more keys to the \"key () pressed?\" and \"when () key pressed\" block dropdowns, such as enter, dot, comma, and more.",
+  "description": "Adds more keys to the \"key () pressed?\" and \"when () key pressed\" block dropdowns, such as \"Enter\", period (full stop), comma, and more.",


The letter is called "dot" in computing context, not "period" or "full stop", according to "en period wikipedia full stop com".

Chrome calls the key (not the character) "period".

apple502j · 2022-02-25T08:20:22Z

    {
      "type": "warning",
-      "text": "The \"Shift keys\" include keys which typically require the Shift key and a number key, like hashtag, exclamation mark and more. These keys only work with the \"when () key pressed\" block and do not work on all operating systems or keyboard layouts.",
+      "text": "The \"Shift keys\" include keys which typically require the Shift key and a number key, like hashtag (pound) and exclamation point. These keys only work with the \"when () key pressed\" block and do not work on all operating systems or keyboard layouts.",


Suggested change

"text": "The \"Shift keys\" include keys which typically require the Shift key and a number key, like hashtag (pound) and exclamation point. These keys only work with the \"when () key pressed\" block and do not work on all operating systems or keyboard layouts.",

"text": "The \"Shift keys\" include keys which typically require the Shift key and a number key, like hashtag and exclamation point. These keys only work with the \"when () key pressed\" block and do not work on all operating systems or keyboard layouts.",

"Pound" is often used to refer to £ sign.

apple502j · 2022-02-25T08:21:17Z

 {
-  "name": "Do not automatically run duplicated blocks",
-  "description": "Fixes a bug in the Scratch editor, where duplicating a block and attaching it to a script causes the script to run.",
+  "name": "Not-automatically-ran duplicated blocks",


This is not German. Do not hyphenate words, it's okay not to nounify in this case.

apple502j · 2022-02-25T08:23:38Z

+    },
+    {
+      "name": "ScratchDB",
+      "url": "http://scratchdb.lefty.one/v3/docs/",


Suggested change

"url": "http://scratchdb.lefty.one/v3/docs/",

"link": "https://scratchdb.lefty.one/v3/docs/",

apple502j · 2022-02-25T08:24:45Z

+    },
+    {
+      "name": "my-ocular.jeffalo.net",
+      "link": "https://ocular.jeffalo.net",


Suggested change

"link": "https://ocular.jeffalo.net",

"link": "https://ocular.jeffalo.net/",

apple502j · 2022-02-25T08:25:10Z

+    {
+      "name": "my-ocular.jeffalo.net",
+      "link": "https://ocular.jeffalo.net",
+      "note": "to obtain data",


Suggested change

"note": "to obtain data",

"note": "data source",

Why not just "data"?

apple502j · 2022-02-25T08:26:05Z

+    {
+      "name": "ScratchDB",
+      "link": "http://scratchdb.lefty.one/v3/docs/",
+      "note": "for information",


Suggested change

"note": "for information",

"note": "statistics data",

apple502j · 2022-02-25T08:29:03Z

+    {
+      "name": "ScratchDB",
+      "url": "http://scratchdb.lefty.one/v3/docs/",
+      "note": "for information",


Suggested change

"note": "for information",

"note": "search result",

Hans5958 · 2022-02-25T08:57:57Z

Use more consistent language 2: Electric Boogaloo

Co-authored-by: apple502j <33279053+apple502j@users.noreply.github.com>

cobaltt7 · 2022-10-11T09:17:47Z

ok you can close this i can’t finish this (i'd close it but i'm locked out of gh website)

mxmou · 2022-10-11T14:24:19Z

@RedGuy12 You already closed this two months ago.

cobaltt7 · 2022-10-11T14:44:53Z

i sent that two months ago why did it just now post

WorldLanguages · 2022-10-11T23:04:17Z

Many weird notifications today - looks like some actions on the GitHub website took 2 months to reflect...?

Samq64 · 2022-10-12T00:56:57Z

I have an unread ghost message from around that time too...

cobaltt7 added 2 commits February 23, 2022 22:20

Fix gramamar and wording

3980d99

Signed-off-by: RedGuy12 <paul@reid-family.org>

e

523a9e3

Signed-off-by: RedGuy12 <paul@reid-family.org>

cobaltt7 requested review from Hans5958, WorldLanguages and apple502j as code owners February 24, 2022 04:23

Hans5958 requested changes Feb 24, 2022

View reviewed changes

apple502j requested changes Feb 24, 2022

View reviewed changes

apple502j changed the title ~~Fix gramamar and wording~~ Fix grammar and wording Feb 24, 2022

WorldLanguages reviewed Feb 24, 2022

View reviewed changes

Comment thread addons-l10n/en/disable-auto-save.json

WorldLanguages reviewed Feb 24, 2022

View reviewed changes

Comment thread addons/scratch-notifier/comment-emojis.js

WorldLanguages reviewed Feb 24, 2022

View reviewed changes

Comment thread security.md

cobaltt7 and others added 6 commits February 24, 2022 21:38

adress review comments

6fbe851

i thought i fixed this

e8ec5d7

Signed-off-by: RedGuy12 <paul@reid-family.org>

Format code

cc032fb

Merge branch 'master' into grammar

690b978

i thought i fixed this

51a4a98

Signed-off-by: RedGuy12 <paul@reid-family.org>

Merge branch 'grammar' of https://github.com/RedGuy12/ScratchAddons i…

5a04873

…nto grammar

cobaltt7 requested review from Hans5958, apple502j and mxmou and removed request for Hans5958 February 25, 2022 04:29

Merge branch 'master' into grammar

99bfb9d

Hans5958 reviewed Feb 25, 2022

View reviewed changes

mxmou reviewed Feb 25, 2022

View reviewed changes

apple502j added priority: 3 Medium priority. Includes bugs and useful features scope: addon Related to one or multiple addons scope: documentation Related to documentation and help resources labels Feb 25, 2022

apple502j added scope: meta Related to the meta of the development (repository, store, etc) scope: webpages Related to the web pages (settings page, pop-up, etc) labels Feb 25, 2022

apple502j requested changes Feb 25, 2022

View reviewed changes

cobaltt7 mentioned this pull request Feb 26, 2022

Add Cmd Key notice to mute-project #4333

Merged

cobaltt7 marked this pull request as draft March 10, 2022 22:19

Update addons/forum-copy-code/addon.json

46625c8

Co-authored-by: apple502j <33279053+apple502j@users.noreply.github.com>

cobaltt7 closed this Aug 2, 2022

Samq64 mentioned this pull request Aug 24, 2023

Rename some addons #6582

Merged

	"description": "Shows ocular statuses and forum post reactions.",
	"description": "Shows ocular statuses and forum post reactions. Uses my-ocular.jeffalo.net to obtain data.",

	"description": "Shows statistics on user profiles.",
	"description": "Shows statistics from ScratchDB on user profiles.",

	"text": "On macOS, use the \"Option\" key instead of the \"Alt\" key and \"Command\" key instead of the \"Ctrl\" key.",
	"text": "On macOS, use the \"Option\" key instead of the \"Alt\" key and \"Cmd\" key instead of the \"Ctrl\" key.",

	"description": "Adds options to right-click menus to export blocks as SVG/PNG images.",
	"description": "Adds options to the code area right-click menu to export blocks as SVG/PNG images.",

	"text": "The \"Shift keys\" include keys which typically require the Shift key and a number key, like hashtag (pound) and exclamation point. These keys only work with the \"when () key pressed\" block and do not work on all operating systems or keyboard layouts.",
	"text": "The \"Shift keys\" include keys which typically require the Shift key and a number key, like hashtag and exclamation point. These keys only work with the \"when () key pressed\" block and do not work on all operating systems or keyboard layouts.",

	"url": "http://scratchdb.lefty.one/v3/docs/",
	"link": "https://scratchdb.lefty.one/v3/docs/",

	"link": "https://ocular.jeffalo.net",
	"link": "https://ocular.jeffalo.net/",

Uh oh!

Conversation

cobaltt7 commented Feb 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Hans5958 Feb 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

apple502j commented Feb 24, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mxmou left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

cobaltt7 commented Feb 24, 2022 •

edited

Loading

Hans5958 Feb 24, 2022 •

edited

Loading