Skip to content

New "colored follower projects" addon - #3086

Closed
codingMASTER398 wants to merge 8 commits into
ScratchAddons:masterfrom
codingMASTER398:master
Closed

New "colored follower projects" addon#3086
codingMASTER398 wants to merge 8 commits into
ScratchAddons:masterfrom
codingMASTER398:master

Conversation

@codingMASTER398

Copy link
Copy Markdown

Colored follower projects addon

What it does:
Adds an addon to change the thumbnail color of projects in the explore tab that have been made by a scratcher you follow.
If you follow a scratcher, all of their projects will appear a different color in the explore tab.

Settings:
Color: The color that the thumbnail will be if you follow the creator of the project
Use other scratchers following: Checkbox, when enabled it uses the people a different scratcher follows
Username of other scratcher: If the previous setting is enabled, you can enter the name of a scratcher in this text box.

This pull request includes only:
-Added "colored-follower-projects" to addons.json
-Added "colored follower projects" addon

@cobaltt7 cobaltt7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also make it work on the front page?

Comment thread addons/colored-follower-projects/userscript.js Outdated
Comment thread addons/colored-follower-projects/userscript.js Outdated
Comment thread addons/colored-follower-projects/userscript.js Outdated
Comment thread addons/colored-follower-projects/userscript.js Outdated
Comment thread addons/colored-follower-projects/addon.json Outdated
@cobaltt7

Copy link
Copy Markdown
Contributor

Try to add dynamic enable/disable too

Not sure myself how it works tho, ask @TheColaber?

Comment thread addons/colored-follower-projects/addon.json Outdated
@codingMASTER398

Copy link
Copy Markdown
Author

Ill work on all of these changes

@codingMASTER398
codingMASTER398 requested a review from cobaltt7 July 25, 2021 00:04
@codingMASTER398

Copy link
Copy Markdown
Author

I have fixed everything you suggested. Thought i might get rid of the "use another scratcher's following" altogether.
Now, it uses waitForElement and works on the homepage!

Comment thread addons/colored-follower-projects/addon.json Outdated

@cobaltt7 cobaltt7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise!

@codingMASTER398

codingMASTER398 commented Jul 25, 2021

Copy link
Copy Markdown
Author

Changed to highlighter
Edit: Fixed the spelling
@RedGuy12 what should i do to get this addon added now?

@danielgallab danielgallab left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can probably remove all the comments, it's easier to read shorter code that way.

Comment on lines +4 to +5
if(addon.auth.isLoggedIn){ // If they are logged in, activate the rest of the code
var username = addon.auth.username // Get the username

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not work because of recent auth changes, aka #2976

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why doesn't it? It works perfectly on my end

@@ -0,0 +1,36 @@
//Hello! I've been scripting for a while now, but i'm not great at keeping my code clean. I'll try to make it readable, but please excuse my mistakes!
export default async function ({ addon, global, console }) {
console.log("Running")

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove log

Comment thread addons/colored-follower-projects/userscript.js Outdated
Comment thread addons/colored-follower-projects/userscript.js
Comment thread addons/colored-follower-projects/userscript.js Outdated
@codingMASTER398

Copy link
Copy Markdown
Author

@WorldLanguages Can you please approve these changes

@WorldLanguages

Copy link
Copy Markdown
Member

@codingMASTER398 Do you find this useful, or was this developed simply for fun as a challenge? This can get merged with a few changes I'd make but please confirm that? The idea is very creative but do you think anyone will make use of this?

@codingMASTER398

Copy link
Copy Markdown
Author

@WorldLanguages I made this for fun and to be useful, and i think people would make a use of this. I would really like it to be merged, so please send what i should change

@WorldLanguages

Copy link
Copy Markdown
Member

I made this for fun and to be useful, and i think people would make a use of this

Can you elaborate why you find it useful?

@lisa-wolfgang

Copy link
Copy Markdown
Member

Can you elaborate why you find it useful?

This is much more useful than the account settings capitalization fix addon, and that addon made it in with no questions asked...

@WorldLanguages

WorldLanguages commented Jul 29, 2021

Copy link
Copy Markdown
Member

This is much more useful than the account settings capitalization fix addon, and that addon made it in with no questions asked...

This isn't really about usefulness if I'm honest, but about balance with other things to consider (addon complexity, Scratch API spam, etc.). That addon is just 3 lines of CSS and non-extension users have talked about it being capitalized incorrectly in the forums, while I don't know about anyone that requested this feature, and this needs many requests to the Scratch API per loaded page, or a way to cache the following list on local storage.

@cobaltt7

Copy link
Copy Markdown
Contributor

Can you go to https://github.com/codingMASTER398/ScratchAddons/actions and enable them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants