Refactor auth API and allow multiple cookie stores - #2976
Merged
Conversation
… into cookie-store-id
… into cookie-store-id
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2965
Fixes a crash when scratch-messaging fails to fetch ST messagesbackported; see #2977Technical changes:
authfromglobalState, since non-addon codes are currently using this. However, this is ignored in content script.Due to the quirks of(change reverted in 966c78c) Content script includes waiting for session to be fetched, as well as cookie-based reading of CSRF token.Listenable,Authis no longer a property ofcommon/Addon.js#Addon. However, all subclasses implement this as either thatAuthorcontent-script/Auth.js#Auth.Scratch Addons now storessatemporarytokencookie on Scratch website when the extension loads. This cookie is used only to fetch the default store ID, will expire either after 10 seconds or after the store ID is grabbed, whichever is sooner. We do not expect this change to have privacy impacts.localState.readyandallReadyno longer includes auth.