Create TurboWarp Player Addon - #2682
Conversation
GarboMuffin
left a comment
There was a problem hiding this comment.
I'm still not fond of the idea of putting TurboWarp into an iframe. Too many hard or impossible to solve issues.
Very selfish request: make "Open tab" the default mode. Or don't. It's not really my choice to make.
GarboMuffin
left a comment
There was a problem hiding this comment.
other feedback:
- In replace player mode, if Scratch either Scratch or TurboWarp are running, it keeps running when mode is switched. That's not ideal.
- For Scratch you could stop or pause the project
- For TurboWarp you could remove the iframe from the DOM instead of just hiding it
Will be solved by #2852 |
|
Can there be the ability to load from different mods, e.g forkphorus? |
|
+ For TurboWarp, could there be a setting for enabling 60fps/high quality pen? |
|
TODOs:
|
|
idea: if the project notes contains a turbowarp link with settings the button redirects to that one |
|
@mxmou Could you 1) tell me if addon name is OK 2) tell me if addon description is OK 3) tell me what you think about the |
I like the title and description, but like #2799 changes the remix tree button addon, I think the project page should not be mentioned in the title - maybe add all information about the button's location to the description instead. In notices, the "replace player" mode should probably be called the "replace player" mode, not just "replace player" mode. I'm not sure if "embed" can be used as a noun - maybe "replaces the Scratch player with an embedded TurboWarp player"? I don't think the background is necessary, and it doesn't fit with Scratch's UI. I think it's better to put the iframe in a container with |
|
TODO: English grammar check for notices |
|
English notices approved by @TheColaber and Grammarly |
Nice |
|
This iframe background looks good, but I still think there should be at least an option to make the TurboWarp stage the same size as Scratch's, with no background. |
Frick yea my addons idea is being added |
I don't think there's a way to do that. Keep in mind the margin you see between the stage and the border is not artificially added by this addon. It's margin inside the iframe. So we can't make it smaller. |
We can. I'll make a PR when I have time. |
Resolves #164
Changes
Creates a button on project pages that lets you toggle from tw to scratch player or open a new tw tab.
Tests
This happens after seeing inside :/

The iframe size is not 100% fine yet