We can keep the stage the exact same size - #3147
Merged
apple502j merged 3 commits intoJul 29, 2021
Merged
Conversation
Member
|
Negative margin, I knew, but I'm a CSS noob 😂 |
Member
|
I added the background/border to have some UI indication that this is not the vanilla Scratch player, do you think we should remove these entirely or try to remind the user in some other way? |
Member
Author
I don't think reminding the user is necessarily - there isn't a way to always automatically replace the Scratch player with the TurboWarp one, so a button needs to be clicked for the replacement to happen anyway. |
Member
|
Do I merge or will you add CSS comments? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #2682 (comment)
Changes
Makes the TurboWarp stage the same size as Scratch's stage and removes the now unnecessary background and border from the iframe.