Changes to support ADFS/WS-Federation SAML2.0 - #129
Closed
sandeep048 wants to merge 6 commits into
Closed
Conversation
Contributor
|
Why create a new PR, when I already closed #126 and commented that those changes are not necessary? |
Author
|
I created a new PR since the previous one had failing tests. I updated some comments in #126. Please have a look. Thanks. |
Author
|
Did you guys do any testing with WS-Fed/ Microsoft Secure Token Service (SAML2.0)?? |
Contributor
|
Yes, we did. |
Contributor
|
The toolkit currently supports ADFS/WS-Federation and don't need proposed changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed to ensure tests are all passing.