Changes to support ADFS/WS-Federation SAML2.0 - #126
Closed
sandeep048 wants to merge 3 commits into
Closed
Conversation
|
|
||
| name_id_policy = '' | ||
| if name_id_policy_format: | ||
| name_id_policy = """<samlp:NameIDPolicy Format="%(name_id_policy)s" AllowCreate="true" />""" % name_id_policy_format |
Contributor
There was a problem hiding this comment.
Why instead don't set at SP settings, the NameIDFormat as "urn:oasis:names:tc:SAML:2.0:nameid-format:unspecified"
Author
There was a problem hiding this comment.
nameid-format:unspecified is not working. For our specific case we wouldn't want the <samlp:NameIDPolicy> tag at all in the generated SAML.
Contributor
There was a problem hiding this comment.
Ok, this is something that I will consider in a future release, to be able to not define NameIDPolicy element.
Contributor
|
I must reject your PR, you don't need those changes in order to be compatible with ADFS/WS-Federation. Read my comments. |
This was referenced Apr 12, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added few extra settings to play nice with Microsoft ADFS/WS-Federation SAML2.0 server.