Sorry for the slow review. Will try to find some time to do it tomorrow.

Feel free to take your time!

We might review and merge in the following order due to dependencies:

#338, #339

@randy3k Is there anything you think should be improved?

LGTM. Sorry for missing it.

By the way, how's its performance for a large project?

renameProvider relies on referencesProivder which again relies on definitionProvider. The performance of renameProvider is almost equal to that of the referencesProvider.

I tried using the Find All References in projects such as languageserver, lintr, data.table, ggplot2, and knitr, and the performance looks good in most cases. In fact, its performance could be poor if we try to find a token which occurs too many times (e.g. more than 1000+) in the projects.

In fact, its performance could be poor if we try to find a token which occurs too many times (e.g. more than 1000+) in the projects.

That's what I was referring to. But anyway, such of use case should not be common.

👍 👍 Thank you for this feature

Great feature, thanks a lot! 👍