Merged
Conversation
Member
|
it seems that the newly added test cases have failed the coverage tests. I will take a look later today. By the way, thank you for working on it. 👍 |
Member
Author
|
There seems to be some difference between the coverage runner and build runners. |
Member
|
LGTM. Merge it at your will. |
randy3k
approved these changes
Oct 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #336
This PR implements a simple referencesProvider based on the current definitionProvider.
R/*.Rfor package or otherwise open R documents in non-package workspace)This PR also provides test cases for the referencesProvider (also based on test cases of the definitionProvider).