Convert public field to property - #14196
Closed
xtqqczze wants to merge 2 commits into
Closed
Conversation
xtqqczze
marked this pull request as ready for review
November 20, 2020 09:49
Collaborator
|
Breaking change in public API? |
Fix SA1623
Contributor
Author
Yes and probably unacceptable, but I would like the change to be considered. |
Paul Higinbotham (PaulHigin)
suggested changes
Nov 23, 2020
|
|
||
| /// <summary> | ||
| /// Gets or sets a value indicating whether Server Manager is enabled. | ||
| /// </summary> |
Contributor
There was a problem hiding this comment.
I am concerned about backward compatibility when converting a public field into a public property.
Collaborator
There was a problem hiding this comment.
Yes, I think we break a binary compatibility.
Collaborator
|
xtqqczze I think we can not approve the change. If you want force the rule please use local suppression for IsServerManager. |
Contributor
Author
|
unacceptable breaking change, closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert public field
PSSessionConfigurationData.IsServerManagerto property.Fix CA2211: Non-constant fields should not be visible.
Breaking change.