Skip to content

Enable CA2211: Non-constant fields should not be visible - #14073

Merged
Ilya (iSazonov) merged 2 commits into
PowerShell:masterfrom
xtqqczze:CA2211
Nov 24, 2020
Merged

Enable CA2211: Non-constant fields should not be visible#14073
Ilya (iSazonov) merged 2 commits into
PowerShell:masterfrom
xtqqczze:CA2211

Conversation

@xtqqczze

Copy link
Copy Markdown
Contributor

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Nov 16, 2020
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Nov 20, 2020
@xtqqczze
xtqqczze marked this pull request as ready for review November 20, 2020 09:07
@iSazonov Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Nov 21, 2020
@iSazonov

Copy link
Copy Markdown
Collaborator

Paul Higinbotham (@PaulHigin) No problem with binary compatibility if we change this?

@PaulHigin

Copy link
Copy Markdown
Contributor

I don't know what you mean. What has changed except warning suppression?

@iSazonov

Copy link
Copy Markdown
Collaborator

Paul Higinbotham (@PaulHigin) Sorry, my comment was for #14196.

@iSazonov
Ilya (iSazonov) merged commit 75e0683 into PowerShell:master Nov 24, 2020
@iSazonov Ilya (iSazonov) added this to the 7.2.0-preview.2 milestone Nov 24, 2020
@xtqqczze
xtqqczze deleted the CA2211 branch November 24, 2020 09:02
@ghost

Copy link
Copy Markdown

🎉v7.2.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants