Skip to content

Fix RCS1098: Constant values should be on right side of comparisons - #13833

Merged
Ilya (iSazonov) merged 2 commits into
PowerShell:masterfrom
xtqqczze:RCS1098
Nov 5, 2020
Merged

Fix RCS1098: Constant values should be on right side of comparisons#13833
Ilya (iSazonov) merged 2 commits into
PowerShell:masterfrom
xtqqczze:RCS1098

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Oct 22, 2020

Copy link
Copy Markdown
Contributor

PR Summary

Avoid so-called Yoda conditions.

PR Context

PR Checklist

@iSazonov
Ilya (iSazonov) self-requested a review October 22, 2020 17:44
@iSazonov Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Oct 22, 2020
@xtqqczze xtqqczze changed the title WIP: Fix RCS1098: Constant values should be on right side of comparisons Fix RCS1098: Constant values should be on right side of comparisons Oct 22, 2020
@ghost ghost added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Oct 25, 2020
@xtqqczze
xtqqczze marked this pull request as ready for review October 28, 2020 00:34
@ghost ghost added the Review - Needed The PR is being reviewed label Nov 4, 2020
@ghost

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@ghost ghost removed the Review - Needed The PR is being reviewed label Nov 5, 2020
@iSazonov
Ilya (iSazonov) merged commit 03a0ef2 into PowerShell:master Nov 5, 2020
@xtqqczze
xtqqczze deleted the RCS1098 branch November 5, 2020 16:27
@ghost

Copy link
Copy Markdown

🎉v7.2.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants