Fix RCS1033: Remove redundant boolean literal part 1 by xtqqczze · Pull Request #13454 · PowerShell/PowerShell

xtqqczze · 2020-08-15T16:29:21Z

PR Summary

Changes should be reviewed with commits combined.

Autofix RCS1033: Remove redundant boolean literal

Due to size, changes to System.Management.Automation were excluded and will be presented in a seperate PR.

PR Context

#13334

PR Checklist

PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
Summarized changes
Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
Breaking changes
- None
- OR
- [NA] Experimental feature(s) needed
  - [NA] Experimental feature name(s):
User-facing changes
- Not Applicable
- OR
- [NA] Documentation needed
  - Issue filed:
Testing - New and feature
- N/A or can only be tested interactively
- OR
- [NA] Make sure you've added a new test if existing tests do not effectively test the code changed
Tooling
- I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
- OR
- [NA] I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
  - Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
  - Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
  - Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
  - Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

Autofix RCS1033: Remove redundant boolean literal

xtqqczze · 2020-08-15T16:39:11Z

Ilya (@iSazonov) Can you review, again :(

xtqqczze · 2020-08-28T21:01:58Z

Travis Plunk (@TravisEz13) can you please review?

Rob Holt (rjmholt) · 2020-09-01T21:24:34Z

xtqqczze what's the full size of all the changes for this? We need to understand the risk for things like commit conflicts and cherry picks. For this and some other style changes, it may be worth opening tracking issues so that work can be broken down into manageable pieces.

Dongbo Wang (daxian-dbw) · 2020-09-01T21:58:56Z

@PowerShell/powershell-maintainers reviewed this PR and agreed to accept it for 7.2-preivew. So we should delay merging it until after 7.1-RC1 release branch gets created.

The changes make sense and the chance of confliction is relatively low, but it requires line-by-line review to make sure there is no potential incorrect change, so it's better to delay merging it till 7.2 preview to avoid possible regression.

Ilya (iSazonov) · 2020-09-02T03:13:54Z

Set to Draft till 7.2 Preview1.

Deleted user (ghost) · 2020-09-20T08:00:08Z

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment.

Deleted user (ghost) · 2020-10-18T20:00:09Z

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment.

Ilya (iSazonov) · 2020-10-19T04:19:59Z

Rob Holt (@rjmholt) Steve Lee (@SteveL-MSFT) I think we can merge.

xtqqczze · 2020-10-22T13:09:49Z

CodeFactor issues are pre-existing.

xtqqczze · 2020-10-22T18:27:47Z

Rob Holt (@rjmholt) Could you help merge, this is blocking #13833.

Deleted user (ghost) · 2020-11-05T02:00:12Z

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

Ilya (iSazonov) · 2020-11-05T05:12:08Z

xtqqczze Please resolve merge conflicts.

Deleted user (ghost) · 2020-11-17T23:01:24Z

🎉v7.2.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Release Notes

* Remove redundant boolean literal Autofix RCS1033: Remove redundant boolean literal * revert changes in System.Management.Automation

xtqqczze added 2 commits August 15, 2020 17:24

Remove redundant boolean literal

b855c9c

Autofix RCS1033: Remove redundant boolean literal

revert changes in System.Management.Automation

5d3dbe5

xtqqczze requested review from Aditya Patwardhan (adityapatwardhan), Andrew (anmenaga) and Dongbo Wang (daxian-dbw) as code owners August 15, 2020 16:29

ghost assigned Rob Holt (rjmholt) Aug 15, 2020

xtqqczze mentioned this pull request Aug 15, 2020

Code redundancy fixes pass 2 #13334

Closed

Rob Holt (rjmholt) added Review - Maintainer The PR/issue needs a review from the PowerShell repo Maintainers Review - Needed The PR is being reviewed labels Aug 15, 2020

Ilya (iSazonov) approved these changes Aug 16, 2020

View reviewed changes

ghost removed the Review - Needed The PR is being reviewed label Sep 1, 2020

Dongbo Wang (daxian-dbw) removed the Review - Maintainer The PR/issue needs a review from the PowerShell repo Maintainers label Sep 1, 2020

Ilya (iSazonov) marked this pull request as draft September 2, 2020 03:13

ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Sep 5, 2020

ghost added the Stale label Sep 20, 2020

ghost closed this Sep 30, 2020

Rob Holt (rjmholt) removed Stale Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Sep 30, 2020

Rob Holt (rjmholt) reopened this Sep 30, 2020

ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Oct 3, 2020

ghost added the Stale label Oct 18, 2020

Ilya (iSazonov) marked this pull request as ready for review October 19, 2020 04:19

ghost removed the Stale label Oct 19, 2020

ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Oct 22, 2020

Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Oct 22, 2020

xtqqczze mentioned this pull request Oct 22, 2020

Fix RCS1098: Constant values should be on right side of comparisons #13833

Merged

8 tasks

xtqqczze changed the title ~~Remove redundant boolean literal part 1~~ Fix RCS1033: Remove redundant boolean literal part 1 Oct 29, 2020

ghost added the Review - Needed The PR is being reviewed label Nov 5, 2020

ghost removed the Review - Needed The PR is being reviewed label Nov 5, 2020

Merge branch 'master' into RCS1033

5b36444

Ilya (iSazonov) approved these changes Nov 5, 2020

View reviewed changes

Ilya (iSazonov) assigned Ilya (iSazonov) and unassigned Rob Holt (rjmholt) Nov 5, 2020

Ilya (iSazonov) merged commit 76be8f3 into PowerShell:master Nov 5, 2020

Ilya (iSazonov) added this to the 7.2.0-preview.1 milestone Nov 5, 2020

xtqqczze deleted the RCS1033 branch November 5, 2020 21:25

Navigation Menu

Uh oh!

Fix RCS1033: Remove redundant boolean literal part 1 - #13454

Fix RCS1033: Remove redundant boolean literal part 1#13454
Ilya (iSazonov) merged 3 commits into
PowerShell:masterfrom
xtqqczze:RCS1033

xtqqczze commented Aug 15, 2020 •

edited

Loading

Uh oh!

xtqqczze commented Aug 15, 2020

Uh oh!

xtqqczze commented Aug 28, 2020

Uh oh!

Rob Holt (rjmholt) commented Sep 1, 2020

Uh oh!

Dongbo Wang (daxian-dbw) commented Sep 1, 2020

Uh oh!

Ilya (iSazonov) commented Sep 2, 2020 •

edited

Loading

Uh oh!

Deleted user (ghost) commented Sep 20, 2020

Uh oh!

Deleted user (ghost) commented Oct 18, 2020

Uh oh!

Ilya (iSazonov) commented Oct 19, 2020

Uh oh!

xtqqczze commented Oct 22, 2020

Uh oh!

xtqqczze commented Oct 22, 2020

Uh oh!

Deleted user (ghost) commented Nov 5, 2020

Uh oh!

Ilya (iSazonov) commented Nov 5, 2020

Uh oh!

Deleted user (ghost) commented Nov 17, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

xtqqczze commented Aug 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

PR Context

PR Checklist

Uh oh!

xtqqczze commented Aug 15, 2020

Uh oh!

xtqqczze commented Aug 28, 2020

Uh oh!

Rob Holt (rjmholt) commented Sep 1, 2020

Uh oh!

Dongbo Wang (daxian-dbw) commented Sep 1, 2020

Uh oh!

Ilya (iSazonov) commented Sep 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Deleted user (ghost) commented Sep 20, 2020

Uh oh!

Deleted user (ghost) commented Oct 18, 2020

Uh oh!

Ilya (iSazonov) commented Oct 19, 2020

Uh oh!

xtqqczze commented Oct 22, 2020

Uh oh!

xtqqczze commented Oct 22, 2020

Uh oh!

Deleted user (ghost) commented Nov 5, 2020

Uh oh!

Ilya (iSazonov) commented Nov 5, 2020

Uh oh!

Deleted user (ghost) commented Nov 17, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

xtqqczze commented Aug 15, 2020 •

edited

Loading

Ilya (iSazonov) commented Sep 2, 2020 •

edited

Loading