Skip to content

Remove unreachable code in CustomShellCommands.cs - #13316

Merged
Rob Holt (rjmholt) merged 1 commit into
PowerShell:masterfrom
xtqqczze:Fix-GH13248
Jul 31, 2020
Merged

Remove unreachable code in CustomShellCommands.cs#13316
Rob Holt (rjmholt) merged 1 commit into
PowerShell:masterfrom
xtqqczze:Fix-GH13248

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Jul 30, 2020

Copy link
Copy Markdown
Contributor

PR Summary

Fix #13248

PR Context

PR Checklist

@xtqqczze xtqqczze changed the title Fix GH13248 Remove unreachable code in CustomShellCommands.cs Jul 30, 2020
@xtqqczze
xtqqczze marked this pull request as ready for review July 30, 2020 15:52
@rjmholt Rob Holt (rjmholt) added the Review - Needed The PR is being reviewed label Jul 30, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rjmholt

Copy link
Copy Markdown
Collaborator

xtqqczze please resolve merge conflicts

@xtqqczze

Copy link
Copy Markdown
Contributor Author

Rob Holt (@rjmholt) resolved

@rjmholt

Copy link
Copy Markdown
Collaborator

PoshChan-Bot (@PoshChan) please remind me in 1 hour

@PoshChan

Copy link
Copy Markdown
Collaborator

Rob Holt (@rjmholt), this is the reminder you requested 1 hour ago

@rjmholt
Rob Holt (rjmholt) merged commit 2eade89 into PowerShell:master Jul 31, 2020
@rjmholt Rob Holt (rjmholt) added CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log and removed Review - Needed The PR is being reviewed labels Jul 31, 2020
@xtqqczze
xtqqczze deleted the Fix-GH13248 branch July 31, 2020 01:11
@iSazonov Ilya (iSazonov) added this to the 7.1.0-preview.7 milestone Jul 31, 2020
@xtqqczze xtqqczze mentioned this pull request Aug 3, 2020
8 tasks
@TravisEz13 Travis Plunk (TravisEz13) modified the milestones: 7.1.0-preview.7, 7.1.0-preview.6 Aug 5, 2020
@ghost

Copy link
Copy Markdown

🎉v7.1.0-preview.6 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unreachable code in CustomShellCommands.cs

7 participants