Skip to content

Mark local variable as const - #13217

Merged
Ilya (iSazonov) merged 13 commits into
PowerShell:masterfrom
xtqqczze:RCS1118
Nov 24, 2020
Merged

Mark local variable as const#13217
Ilya (iSazonov) merged 13 commits into
PowerShell:masterfrom
xtqqczze:RCS1118

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Jul 20, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

PR Summary

PR Context

PR Checklist

iSazonov
Ilya (iSazonov) reviewed Jul 21, 2020
View reviewed changes
Comment thread ...stem.Management.Automation/FormatAndOutput/common/DisplayDatabase/typeDataXmlLoader_Table.cs Outdated
Comment thread src/System.Management.Automation/engine/Modules/ModuleIntrinsics.cs Outdated
Comment thread src/System.Management.Automation/engine/remoting/common/WireDataFormat/EncodeAndDecode.cs Outdated
Comment thread src/System.Management.Automation/engine/remoting/common/WireDataFormat/EncodeAndDecode.cs Outdated
xtqqczze
xtqqczze commented Jul 21, 2020
View reviewed changes
Comment thread src/System.Management.Automation/engine/remoting/commands/CustomShellCommands.cs Outdated
This was referenced Jul 23, 2020
Closed
Closed
@xtqqczze
xtqqczze force-pushed the RCS1118 branch 2 times, most recently from 7c0dc96 to 3bc6352 Compare July 23, 2020 12:42
iSazonov
Ilya (iSazonov) approved these changes Jul 23, 2020
View reviewed changes
Comment thread src/System.Management.Automation/engine/NativeCommandParameterBinder.cs Outdated
@iSazonov Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Jul 23, 2020
rjmholt
Rob Holt (rjmholt) reviewed Jul 23, 2020
View reviewed changes
Comment thread src/Microsoft.PowerShell.ConsoleHost/host/msh/ConsoleHostUserInterfacePrompt.cs Outdated
@xtqqczze

xtqqczze commented Jul 25, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Ilya (@iSazonov) It seems analyzers do not find code fixes inside an #if directive (unless the expression is true at compile time). This means code fixes inside #if UNIX etc have been missed from previous PRs. (Roslynator issue)

@xtqqczze
xtqqczze marked this pull request as ready for review July 25, 2020 17:35
@rjmholt

Rob Holt (rjmholt) commented Jul 26, 2020

Copy link
Copy Markdown
Collaborator

I'll give some extra time for other reviewers. They're likely to be out next week, so we may have to wait a little whlie

@iSazonov

Ilya (iSazonov) commented Jul 27, 2020

Copy link
Copy Markdown
Collaborator

It seems analyzers do not find code fixes inside an #if directive

xtqqczze It is expected - the analyzers work at compile. You could target an Unix while run analyzers. But it is not critical.

@rjmholt

Rob Holt (rjmholt) commented Jul 27, 2020

Copy link
Copy Markdown
Collaborator

PoshChan-Bot (@PoshChan) please remind me in 10 days

@rjmholt Rob Holt (rjmholt) added the Review - Needed The PR is being reviewed label Jul 28, 2020
@ghost ghost removed the Review - Needed The PR is being reviewed label Jul 30, 2020
@xtqqczze

xtqqczze commented Aug 3, 2020

Copy link
Copy Markdown
Contributor Author

rebased to resolve #13316 conflict

@ghost

Deleted user (ghost) commented Oct 18, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment.

@ghost ghost added the Stale label Oct 18, 2020
@iSazonov
Ilya (iSazonov) marked this pull request as ready for review October 19, 2020 04:18
@iSazonov

Ilya (iSazonov) commented Oct 19, 2020

Copy link
Copy Markdown
Collaborator

Rob Holt (@rjmholt) Steve Lee (@SteveL-MSFT) I think we can merge.

@ghost ghost removed the Stale label Oct 19, 2020
@ghost ghost added the Stale label Nov 3, 2020
@ghost

Deleted user (ghost) commented Nov 3, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment.

@xtqqczze

xtqqczze commented Nov 3, 2020

Copy link
Copy Markdown
Contributor Author

This PR is ready for final review.

@ghost ghost removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept Stale labels Nov 3, 2020
@iSazonov

Ilya (iSazonov) commented Nov 5, 2020

Copy link
Copy Markdown
Collaborator

xtqqczze Please resolve merge conflicts.

@ghost ghost added the Review - Needed The PR is being reviewed label Nov 12, 2020
@ghost

Deleted user (ghost) commented Nov 12, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@xtqqczze
xtqqczze marked this pull request as draft November 13, 2020 01:04
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Nov 16, 2020
@iSazonov

Ilya (iSazonov) commented Nov 18, 2020

Copy link
Copy Markdown
Collaborator

xtqqczze Is it still Draft?

@ghost ghost removed the Review - Needed The PR is being reviewed label Nov 18, 2020
@xtqqczze
xtqqczze marked this pull request as ready for review November 18, 2020 08:41
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Nov 18, 2020
@iSazonov

Ilya (iSazonov) commented Nov 21, 2020

Copy link
Copy Markdown
Collaborator

xtqqczze Please resolve merge conflicts.

1 similar comment
@iSazonov

Ilya (iSazonov) commented Nov 24, 2020

Copy link
Copy Markdown
Collaborator

xtqqczze Please resolve merge conflicts.

@iSazonov
Ilya (iSazonov) merged commit c7bdb24 into PowerShell:master Nov 24, 2020
@iSazonov Ilya (iSazonov) added this to the 7.2.0-preview.2 milestone Nov 24, 2020
@xtqqczze
xtqqczze deleted the RCS1118 branch November 24, 2020 16:30
@ghost

Deleted user (ghost) commented Dec 15, 2020

Copy link
Copy Markdown

🎉v7.2.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
@xtqqczze
Mark local variable as const (PowerShell#13217)
b29b091 
RCS1118: Mark local variable as const https://github.com/JosefPihrt/Roslynator/blob/master/docs/analyzers/RCS1118.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov Ilya (iSazonov) iSazonov approved these changes
@SteveL-MSFT Steve Lee (SteveL-MSFT) Awaiting requested review from SteveL-MSFT
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw daxian-dbw is a code owner
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan adityapatwardhan is a code owner
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@TravisEz13 Travis Plunk (TravisEz13) Awaiting requested review from TravisEz13 TravisEz13 is a code owner
+1 more reviewer
@rjmholt Rob Holt (rjmholt) rjmholt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@rjmholt Rob Holt (rjmholt)

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.2

Development

Successfully merging this pull request may close these issues.

4 participants

@xtqqczze @rjmholt @iSazonov @daxian-dbw