Skip to content

Increment iso639 length - #466

Merged
Naramsim merged 5 commits into
masterfrom
iso639-length
Feb 23, 2020
Merged

Increment iso639 length#466
Naramsim merged 5 commits into
masterfrom
iso639-length

Conversation

@Naramsim

Copy link
Copy Markdown
Member

Veekun decided that iso639 can have more than 2 characters.

To be merged after #465

Kronopt
Kronopt previously approved these changes Jan 17, 2020
tasadurian
tasadurian previously approved these changes Jan 17, 2020
@Naramsim
Naramsim requested a review from phalt January 17, 2020 21:15
GregHilmes
GregHilmes previously approved these changes Jan 18, 2020
phalt
phalt previously approved these changes Jan 21, 2020

@phalt phalt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for when ready

@Naramsim
Naramsim dismissed stale reviews from phalt, GregHilmes, tasadurian, and Kronopt via 644a491 January 26, 2020 11:43
@Naramsim
Naramsim requested review from phalt and removed request for neverendingqs January 26, 2020 11:44
@phalt

phalt commented Feb 17, 2020

Copy link
Copy Markdown
Member

@Naramsim removed the approval?

@Naramsim
Naramsim merged commit c7e10bd into master Feb 23, 2020
@Naramsim
Naramsim deleted the iso639-length branch February 23, 2020 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants