Fix scrubbing for rare cases - #465
Merged
Merged
Conversation
Merged
Naramsim
requested review from
GregHilmes,
Kronopt,
neverendingqs and
tasadurian
January 17, 2020 12:23
Kronopt
previously approved these changes
Jan 17, 2020
tasadurian
previously approved these changes
Jan 17, 2020
GregHilmes
previously approved these changes
Jan 18, 2020
phalt
previously approved these changes
Jan 21, 2020
Naramsim
dismissed stale reviews from phalt, GregHilmes, tasadurian, and Kronopt
via
January 26, 2020 11:41
3e2e08f
Member
Author
|
Reviews were automatically dismissed when I resolved some conflicts. |
tasadurian
approved these changes
Jan 26, 2020
Member
Author
|
@Kronopt, @tasadurian hello! I don't have your emails so I text you here. I just spoke with @phalt and @tdmalone about promoting you to have write-access to this repository so that we can collaborate and get these PRs merged :) I think the two of you are quite active on Github and you also care about our project. If it's fine for you I'll 'promote' you. Let me know in a comment below. Thanks!! |
Member
|
@Naramsim sounds good |
Contributor
|
I'm fine with it! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
veekun/pokedex#291
veekun/pokedex#290
To be merged after #464