Added C-API hash function, used them in Python interface#491
Merged
oleksandr-pavlyk merged 9 commits intomasterfrom Jun 21, 2021
Merged
Added C-API hash function, used them in Python interface#491oleksandr-pavlyk merged 9 commits intomasterfrom
oleksandr-pavlyk merged 9 commits intomasterfrom
Conversation
Collaborator
Contributor
Author
|
@diptorupd CI is failing in testing-wheels, and I am not entirely sure why. I was able to to |
Contributor
|
@oleksandr-pavlyk I suggest drop 41bd9ab from the PR. It unnecessarily will introduce an incomplete fix into our master. |
Contributor
Author
I will do a gentle history rewriting once the CI winks an approval. |
- SyclContext, SyclDevice, SyclQueue classes previously where
not hashable. The PR defines __hash__ function based on the
C API DPCTL<Obj>_Hash function.
…re being installed into Python environment and should be used instead of those in the compiler installation
8eb4915 to
a005320
Compare
diptorupd
previously approved these changes
Jun 21, 2021
Contributor
diptorupd
left a comment
There was a problem hiding this comment.
Minor documentation fixes. Otherwise, LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #483
Superseded #489 (and reuses some changes from there).