Defines __hash__ for all classes that define __eq__ method.#489
Closed
diptorupd wants to merge 1 commit intoIntelPython:masterfrom
Closed
Defines __hash__ for all classes that define __eq__ method.#489diptorupd wants to merge 1 commit intoIntelPython:masterfrom
diptorupd wants to merge 1 commit intoIntelPython:masterfrom
Conversation
- SyclContext, SyclDevice, SyclQueue classes previously where
not hashable. The PR defines __hash__ function based on the
C API native pointer value stored in the classes.
Contributor
|
I think simply hashing the address is not enough. We also need to use |
Contributor
Author
|
superseded by #491 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
not hashable. The PR defines hash function based on the
C API native pointer value stored in the classes.
Closes #483