Merged
Conversation
1. `flake8`, `isort` jobs added to check for Python code style for new PRs against `master`, `gold/2021`, `release` branches. 2. `black` max line width changed to 80 chars. 3. `flake8` and `isort` configs added. 4. `pre-commit` hooks added to make it possible to run all these checks prior to pushing code. 5. `CONTRIBUTION.md` updated.
f5e1b2b to
084ba59
Compare
diptorupd
approved these changes
Apr 30, 2021
diptorupd
pushed a commit
to diptorupd/dpctl
that referenced
this pull request
May 1, 2021
diptorupd
pushed a commit
that referenced
this pull request
May 1, 2021
This was referenced May 1, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit history housekeeping PR that superseded #416 and #414 and #421.