Skip to content

Fix/code style#416

Closed
diptorupd wants to merge 6 commits intoIntelPython:masterfrom
diptorupd:fix/code_style
Closed

Fix/code style#416
diptorupd wants to merge 6 commits intoIntelPython:masterfrom
diptorupd:fix/code_style

Conversation

@diptorupd
Copy link
Copy Markdown
Contributor

@oleksandr-pavlyk I fixed most of the issues in our Cython files found using flake and applied isort and black. One issue I ran into was that the order of imports in __init__.py matters. With the sorted imports in the file the tests fail to execute. For this reason, I reverted the changes isort made to __init__.py.

@diptorupd
Copy link
Copy Markdown
Contributor Author

diptorupd commented Apr 30, 2021

@oleksandr-pavlyk I fixed almost all the flake8 issues. Some of the issues need to be ignored as these are not applicable to Cython. I have rebased this PR on top of #412, so you can see the last few pending issues in the CI.

@diptorupd diptorupd closed this Apr 30, 2021
@diptorupd diptorupd deleted the fix/code_style branch May 1, 2021 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants