New getting started on Compute Engine sample. - #432
Conversation
|
Should probably use the java-docs-samples parent for checkstyle and errorprone as well. |
Co-Authored-By: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>
Done |
a1f81e7 to
8204e83
Compare
|
I'm not sure what's going on with this Java 8 failure, though it seems to happen with the bookshelf/6-gce as well (though those tests don't seem to run as part of presubmit, continuous, or periodic, so they aren't setting off any flags). |
My guess is that the POM for this branch doesn't have it as a dependency, so it's not running on system tests. If we are going to move these samples anyway, it might be easiest just to PR this to java-docs-samples. |
|
Got it - needed to specify some selenium executions params in pom.xml that it had been inheriting via the bookshelf parent tree but didn't come from shared-configuration. |
|
Still gonna complain about the chrome webdriver executable though I guess. |
6691965 to
3430b1a
Compare
|
Also, I didn't think we were moving these samples out of getting-started-java, since they are still part of the getting started experience. Am I forgetting something? |
According to the tracking doc, we decided to move them into java-docs-samples. But maybe it changed and we just didn't update it. |
|
So was the plan to deprecate this repo entirely? |
|
All right, but I would want to do that as a separate task instead of ballooning this one. |
👍 |
Creating in new base /gce directory instead of overwriting the existing
bookshelf/6-gce, as this is where we'll want the code to live and it avoids overwriting the current sample without needing a named branch.Much of this is taken directly from
bookshelf/6-gcethough, including:most of
makeProject->6-gce/makeBookshelfpom.xmlreduced from6-gce/makeBookshelfeverything in
src/main/appengineandsrc/main/webapp.scripts/startup-script.shslightly modified from6-gce/makeBookshelf/gce/startup-script.sh