Add HTTP Nowhere mode to Chromium - #603
Conversation
Adds mode for blocking HTTP requests entirely after HTTPS Everywhere rewrites. Switches UI button from PageAction to BrowserAction, because why was it a PageAction in the first place?
|
Nice work! I'll review this in a bit. What are your thoughts on the pageAction -> browserAction switch and the UX change? (I think I'd added that comment originally) |
|
Friendly ping @diracdeltas -- thoughts on pageaction vs browseraction switching? I'd added that comment originally, though now I have mixed thoughts. My chrome extension space is super busy ... and I kinda like that HTTPSe is hanging out with the URL address bar. |
|
@semenko, @diracdeltas, what's the status of this? Still needs review? |
|
Will take a look again, biggest point is this is really two changes. One is a Chrome UX change that switches the HTTPSe icon from URL bar (pageaction) to on every page as a button (browseraction). |
|
I think switching the icon to be a BrowserAction is fine. It's not consistent with browser guidelines, but it's consistent with our other plugin, Privacy Badger. |
|
Ok -- taking a look at this now. @jsha should we be merging this into 4.0 vs master? First notes: HTTP Nowhere mode doesn't seem to be working 100% for me. Some pages (Chrome prerender replaced?) seem to bypass this mode. Will update / patch. |
|
Let's merge to master, since I'll be promoting master to stable sometime this month. |
There was a problem hiding this comment.
Just being explicit, since this is a dangerous file to change: 'storage' does not cause additional permissions warnings, per:
https://developer.chrome.com/extensions/permission_warnings
|
How's this going? |
|
Fell to the back burner for a while -- will take a look soon |
|
Let me know if you need help on getting this merged! Also, note that this introduces use of |
|
Sorry, still on the back burner until a few more things are hammered out for a manuscript. Last I checked, this wasn't working as expected -- I think prerendered tabs were ignored, or something similar. (At the least, I'll break out the UX change into a separate PR) |
|
Ok -- tracked down the bug in this. Will rebase and probably open a new PR (since i'm hesitant to ever use git --force ...) |
|
rebased & opened #1295 |
Adds mode for blocking HTTP requests entirely after HTTPS Everywhere
rewrites. Switches UI button from PageAction to BrowserAction.