This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Add HTTP Nowhere mode to Chromium - #1295
Merged
Merged
Conversation
Adds mode for blocking HTTP requests entirely after HTTPS Everywhere rewrites. Switches UI button from PageAction to BrowserAction, because why was it a PageAction in the first place?
Signed-off-by: Nick Semenkovich <semenko@alum.mit.edu>
Contributor
Author
|
Ok LGTM -- going to go ahead and merge since this is @diracdeltas's #603 rebased + tiny patch |
semenko
added a commit
that referenced
this pull request
Mar 27, 2015
Add HTTP Nowhere mode to Chromium
Member
|
LGTM too. Thanks for reviewing and merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased w/ change from Yan's #603:
"""
Adds mode for blocking HTTP requests entirely after HTTPS Everywhere
rewrites. Switches UI button from PageAction to BrowserAction.
"""
(Still going to review a bit & may expand this PR more -- please don't merge just yet)