Skip to content

Implement #804, move some functions to Units - #812

Merged
lethosor merged 2 commits into
DFHack:developfrom
kazimuth:zone-unassign
Apr 24, 2016
Merged

Implement #804, move some functions to Units#812
lethosor merged 2 commits into
DFHack:developfrom
kazimuth:zone-unassign

Conversation

@kazimuth

@kazimuth kazimuth commented Feb 1, 2016

Copy link
Copy Markdown
Contributor

Also colorize output from the zone plugin, and clean it up a tiny bit.

@BenLubar

BenLubar commented Feb 1, 2016

Copy link
Copy Markdown
Member

@kazimuth you've got some trailing whitespace that Travis is objecting to.

@kazimuth

kazimuth commented Feb 2, 2016

Copy link
Copy Markdown
Contributor Author

Fixed, thanks @BenLubar.

@expwnent

Copy link
Copy Markdown
Member

#804

I think references don't work in titles.

@expwnent expwnent added this to the 0.42.xx-r1 milestone Mar 13, 2016
@lethosor

Copy link
Copy Markdown
Member

Need to confirm if this stuff works with MSVC and GCC 4.5:

// ZONE FILTERS (as in, filters used by 'zone')

// Maps parameter names to filters.
unordered_map<string, function<bool(df::unit*)>> zone_filters = {
    { "caged", isContainedInItem },
    { "egglayer", isEggLayer },

@BenLubar

Copy link
Copy Markdown
Member

Merge conflict is just in the #include part of Units.cpp. As for compatibility:

..\..\..\plugins\zone.cpp(1320): error C2552: 'zone_filters' : non-aggregates cannot be initialized with initializer list [C:\Users\Owner\Documents\GitHub\dfhack\build\VC2010\plugins\zone.vcxproj]
..\..\..\plugins\zone.cpp(1321): error C2078: too many initializers [C:\Users\Owner\Documents\GitHub\dfhack\build\VC2010\plugins\zone.vcxproj]
..\..\..\plugins\zone.cpp(1322): fatal error C1903: unable to recover from previous error(s); stopping compilation [C:\Users\Owner\Documents\GitHub\dfhack\build\VC2010\plugins\zone.vcxproj]

@lethosor
lethosor merged commit 5d8c2fd into DFHack:develop Apr 24, 2016
lethosor added a commit that referenced this pull request Apr 24, 2016
@kazimuth
kazimuth deleted the zone-unassign branch April 25, 2016 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants