This repository was archived by the owner on Jan 14, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 279
Glasgow Class 6 - Man Sang Sin - JS1 - Week 3 #255
Open
ManSangSin
wants to merge
4
commits into
CodeYourFuture:main
Choose a base branch
from
ManSangSin:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,52 +12,58 @@ | |
| */ | ||
|
|
||
| function getTemperatureReport(cities) { | ||
| // TODO | ||
| // TODO | ||
| let numberOfCities = cities.length; | ||
| const cityTempDataArr = []; | ||
| for (let i = 0; i < numberOfCities; i++) { | ||
| let cityTemp = temperatureService(cities[i]); | ||
| cityTempDataArr.push( | ||
| `The temperature in ${cities[i]} is ${cityTemp} degrees` | ||
| ); | ||
| } | ||
| return cityTempDataArr; | ||
| } | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Really like your naming the variable very readable. |
||
|
|
||
|
|
||
| /* ======= TESTS - DO NOT MODIFY ===== */ | ||
|
|
||
| function temperatureService(city) { | ||
| let temparatureMap = new Map(); | ||
|
|
||
| temparatureMap.set('London', 10); | ||
| temparatureMap.set('Paris', 12); | ||
| temparatureMap.set('Barcelona', 17); | ||
| temparatureMap.set('Dubai', 27); | ||
| temparatureMap.set('Mumbai', 29); | ||
| temparatureMap.set('São Paulo', 23); | ||
| temparatureMap.set('Lagos', 33); | ||
| return temparatureMap.get(city); | ||
| let temparatureMap = new Map(); | ||
|
|
||
| temparatureMap.set("London", 10); | ||
| temparatureMap.set("Paris", 12); | ||
| temparatureMap.set("Barcelona", 17); | ||
| temparatureMap.set("Dubai", 27); | ||
| temparatureMap.set("Mumbai", 29); | ||
| temparatureMap.set("São Paulo", 23); | ||
| temparatureMap.set("Lagos", 33); | ||
|
|
||
| return temparatureMap.get(city); | ||
| } | ||
|
|
||
| test("should return array of same length as arguement", () => { | ||
| let usersCities = ["London", "Paris", "São Paulo"]; | ||
| expect(getTemperatureReport(usersCities).length).toEqual(3); | ||
| }); | ||
|
|
||
| test("should return a temperature report for the user's cities", () => { | ||
| let usersCities = [ | ||
| "London", | ||
| "Paris", | ||
| "São Paulo" | ||
| ] | ||
|
|
||
| expect(getTemperatureReport(usersCities)).toEqual([ | ||
| "The temperature in London is 10 degrees", | ||
| "The temperature in Paris is 12 degrees", | ||
| "The temperature in São Paulo is 23 degrees" | ||
| ]); | ||
| let usersCities = ["London", "Paris", "São Paulo"]; | ||
|
|
||
| expect(getTemperatureReport(usersCities)).toEqual([ | ||
| "The temperature in London is 10 degrees", | ||
| "The temperature in Paris is 12 degrees", | ||
| "The temperature in São Paulo is 23 degrees", | ||
| ]); | ||
| }); | ||
|
|
||
| test("should return a temperature report for the user's cities (alternate input)", () => { | ||
| let usersCities = [ | ||
| "Barcelona", | ||
| "Dubai" | ||
| ] | ||
|
|
||
| expect(getTemperatureReport(usersCities)).toEqual([ | ||
| "The temperature in Barcelona is 17 degrees", | ||
| "The temperature in Dubai is 27 degrees" | ||
| ]); | ||
| let usersCities = ["Barcelona", "Dubai"]; | ||
|
|
||
| expect(getTemperatureReport(usersCities)).toEqual([ | ||
| "The temperature in Barcelona is 17 degrees", | ||
| "The temperature in Dubai is 27 degrees", | ||
| ]); | ||
| }); | ||
|
|
||
| test("should return an empty array if the user hasn't selected any cities", () => { | ||
| expect(getTemperatureReport([])).toEqual([]); | ||
| }); | ||
| expect(getTemperatureReport([])).toEqual([]); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,7 +5,15 @@ | |
| Implement the function below, which will return a new array containing only article titles which will fit. | ||
| */ | ||
| function potentialHeadlines(allArticleTitles) { | ||
| // TODO | ||
| // TODO: iterate over all the articles in the input array and check if the article string is less than or equal to 65, if true: add to validTitleArr array. | ||
| let numberOfTitles = allArticleTitles.length; | ||
| let validTitleArr = []; | ||
| for (i = 0; i < numberOfTitles; i++) { | ||
| if (allArticleTitles[i].length <= 65) { | ||
| validTitleArr.push(allArticleTitles[i]); | ||
| } | ||
| } | ||
| return validTitleArr; | ||
| } | ||
|
|
||
| /* | ||
|
|
@@ -14,7 +22,18 @@ function potentialHeadlines(allArticleTitles) { | |
| (you can assume words will always be seperated by a space) | ||
| */ | ||
| function titleWithFewestWords(allArticleTitles) { | ||
| // TODO | ||
| // TODO: for each article string, split the string and count the number of words which should equal the number of array items. If the current number of array items is less than the value stored in the shortestTitle variable, set current article title as the new value. | ||
| let shortestTitle = ""; | ||
| for (const article of allArticleTitles) { | ||
| let wordsInTitleArr = article.split(" "); | ||
| let shortestTitleArr = shortestTitle.split(" "); | ||
| let wordCount = wordsInTitleArr.length; | ||
| let shortestTitleCount = shortestTitleArr.length; | ||
| if (wordCount < shortestTitleCount || shortestTitle === "") { | ||
| shortestTitle = article; | ||
| } | ||
| } | ||
| return shortestTitle; | ||
| } | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. amazing thinking finding the solution, it took a long time for me. |
||
|
|
||
| /* | ||
|
|
@@ -23,59 +42,80 @@ function titleWithFewestWords(allArticleTitles) { | |
| (Hint: remember that you can also loop through the characters of a string if you need to) | ||
| */ | ||
| function headlinesWithNumbers(allArticleTitles) { | ||
| // TODO | ||
| // TODO: iterate through each title, and iterate each character to check if character is a number. if true add to new array. | ||
| const articlesWithNumbers = []; | ||
| let numberOfArticles = allArticleTitles.length; | ||
| console.log(numberOfArticles); | ||
| for (let i = 0; i < numberOfArticles; i++) { | ||
| if (/[0-9]/.test(allArticleTitles[i])) { | ||
| articlesWithNumbers.push(allArticleTitles[i]); | ||
| } | ||
| } | ||
| return articlesWithNumbers; | ||
| } | ||
|
|
||
| /* | ||
| The Financial Times wants to understand what the average number of characters in an article title is. | ||
| Implement the function below to return this number - rounded to the nearest integer. | ||
| */ | ||
| function averageNumberOfCharacters(allArticleTitles) { | ||
| // TODO | ||
| // TODO: iterate through each title, and iterate each character. for each character add +1 to characterCount. divide characterCount by the number of articles. Use Math.round method | ||
| let characterCount = 0; | ||
| let numberOfArticles = allArticleTitles.length; | ||
| for (const article of allArticleTitles) { | ||
| for (const character of article) { | ||
| characterCount++; | ||
| } | ||
| } | ||
| return Math.round(characterCount / numberOfArticles); | ||
| } | ||
|
|
||
|
|
||
|
|
||
| /* ======= List of Articles - DO NOT MODIFY ===== */ | ||
| const ARTICLE_TITLES = [ | ||
| "Streaming wars drive media groups to spend more than $100bn on new content", | ||
| "Amazon Prime Video India country head: streaming is driving a TV revolution", | ||
| "Aerospace chiefs prepare for bumpy ride in recovery of long-haul flights", | ||
| "British companies look to muscle in on US retail investing boom", | ||
| "Libor to take firm step towards oblivion on New Year's Day", | ||
| "Audit profession unattractive to new recruits, says PwC boss", | ||
| "Chinese social media users blast Elon Musk over near miss in space", | ||
| "Companies raise over $12tn in 'blockbuster' year for global capital markets", | ||
| "The three questions that dominate investment", | ||
| "Brussels urges Chile's incoming president to endorse EU trade deal", | ||
| "Streaming wars drive media groups to spend more than $100bn on new content", | ||
| "Amazon Prime Video India country head: streaming is driving a TV revolution", | ||
| "Aerospace chiefs prepare for bumpy ride in recovery of long-haul flights", | ||
| "British companies look to muscle in on US retail investing boom", | ||
| "Libor to take firm step towards oblivion on New Year's Day", | ||
| "Audit profession unattractive to new recruits, says PwC boss", | ||
| "Chinese social media users blast Elon Musk over near miss in space", | ||
| "Companies raise over $12tn in 'blockbuster' year for global capital markets", | ||
| "The three questions that dominate investment", | ||
| "Brussels urges Chile's incoming president to endorse EU trade deal", | ||
| ]; | ||
|
|
||
| /* ======= TESTS - DO NOT MODIFY ===== */ | ||
|
|
||
| test("should only return potential headlines", () => { | ||
| expect(new Set(potentialHeadlines(ARTICLE_TITLES))).toEqual(new Set([ | ||
| "British companies look to muscle in on US retail investing boom", | ||
| "Libor to take firm step towards oblivion on New Year's Day", | ||
| "Audit profession unattractive to new recruits, says PwC boss", | ||
| "The three questions that dominate investment" | ||
| ])); | ||
| expect(new Set(potentialHeadlines(ARTICLE_TITLES))).toEqual( | ||
| new Set([ | ||
| "British companies look to muscle in on US retail investing boom", | ||
| "Libor to take firm step towards oblivion on New Year's Day", | ||
| "Audit profession unattractive to new recruits, says PwC boss", | ||
| "The three questions that dominate investment", | ||
| ]) | ||
| ); | ||
| }); | ||
|
|
||
| test("should return an empty array for empty input", () => { | ||
| expect(potentialHeadlines([])).toEqual([]); | ||
| expect(potentialHeadlines([])).toEqual([]); | ||
| }); | ||
|
|
||
| test("should return the title with the fewest words", () => { | ||
| expect(titleWithFewestWords(ARTICLE_TITLES)).toEqual("The three questions that dominate investment"); | ||
| expect(titleWithFewestWords(ARTICLE_TITLES)).toEqual( | ||
| "The three questions that dominate investment" | ||
| ); | ||
| }); | ||
|
|
||
| test("should only return headlines containing numbers", () => { | ||
| expect(new Set(headlinesWithNumbers(ARTICLE_TITLES))).toEqual(new Set([ | ||
| "Streaming wars drive media groups to spend more than $100bn on new content", | ||
| "Companies raise over $12tn in 'blockbuster' year for global capital markets" | ||
| ])); | ||
| expect(new Set(headlinesWithNumbers(ARTICLE_TITLES))).toEqual( | ||
| new Set([ | ||
| "Streaming wars drive media groups to spend more than $100bn on new content", | ||
| "Companies raise over $12tn in 'blockbuster' year for global capital markets", | ||
| ]) | ||
| ); | ||
| }); | ||
|
|
||
| test("should return the average number of characters in a headline", () => { | ||
| expect(averageNumberOfCharacters(ARTICLE_TITLES)).toEqual(65); | ||
| expect(averageNumberOfCharacters(ARTICLE_TITLES)).toEqual(65); | ||
| }); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like your use of the for loop.