This repository was archived by the owner on Jan 14, 2024. It is now read-only.
Glasgow Class 6 - Man Sang Sin - JS1 - Week 3 - #255
Open
ManSangSin wants to merge 4 commits into
Open
Conversation
- completed exercises A-E
- added brackets to if statement
- completed mandatory exercises 1-3
Joemwa
reviewed
Mar 11, 2023
| for (let i = 0; i < numberOfBirthdays; i++) { | ||
| if (BIRTHDAYS[i].includes("July")) { | ||
| return BIRTHDAYS[i]; | ||
| break; |
| ); | ||
| } | ||
| return cityTempDataArr; | ||
| } |
There was a problem hiding this comment.
Really like your naming the variable very readable.
| } | ||
| } | ||
| return shortestTitle; | ||
| } |
There was a problem hiding this comment.
amazing thinking finding the solution, it took a long time for me.
one tip would be to do more frequent git push.
| priceChange = | ||
| closingPricesForIndividualCompany[4] - | ||
| closingPricesForIndividualCompany[0]; | ||
| // add priceChange value to array priceChangeArr. The value is rounded to 2 decimal using math.round and multiplied by 100 then divided by 100 |
There was a problem hiding this comment.
wow that very smart way to solve this one, and amazing work with the comments i should start writing more comments in my code as well.
AppolinFotso
left a comment
There was a problem hiding this comment.
Well done @ManSangSin! Your codes are clean and readable.
I like the way you named your variables, it looks amazing.
- added a test to check the length of array from instructions: JS2 Week1 -Practice write a first test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.