This repository was archived by the owner on Jan 14, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 475
Glasgow Class 6 - nasir ali - JS1 - Week 1 #478
Open
ali-nasir-ali
wants to merge
11
commits into
CodeYourFuture:master
Choose a base branch
from
ali-nasir-ali:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
143d1ea
fixed 1 and 2 tests
ali-nasir-ali 96072f5
fixed and added comments to 3
ali-nasir-ali 8d4139d
fixed 4 in mandatory
ali-nasir-ali 70d5bc3
fixed extra 1
ali-nasir-ali fb1f8f4
fixed extra 2
ali-nasir-ali 307329d
got an error in processing array name
ali-nasir-ali 897396b
done extra 3
ali-nasir-ali 4305fc3
trying different things
ali-nasir-ali bf50e33
finaly fixed the 8 ball
ali-nasir-ali 1161b2f
8 ball final checks of minor errors
ali-nasir-ali c64ebd8
fixed the extra 1
ali-nasir-ali File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @ali-nasir-ali ,
Thank your submission - seeing some great work here! Excellent start!
Your tests for the extra section aren't quite passing at the moment. Here are a few things to consider:
checkAnswer:Look carefully at how
checkAnsweris being called here in this test. What argument is being passed tocheckAnswer?Compare this with your current implementation of
checkAnswerto see if you can figure out how to update the function.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Mitch Lloyd, with your help I finally figured out that the function name was literal not figurative. and was able to solve it by googling the write questions. Again many thanks.