Skip to content
This repository was archived by the owner on Jan 14, 2024. It is now read-only.

Glasgow Class 6 - nasir ali - JS1 - Week 1 - #478

Open
ali-nasir-ali wants to merge 11 commits into
CodeYourFuture:masterfrom
ali-nasir-ali:master
Open

Glasgow Class 6 - nasir ali - JS1 - Week 1 #478
ali-nasir-ali wants to merge 11 commits into
CodeYourFuture:masterfrom
ali-nasir-ali:master

Conversation

@ali-nasir-ali

Copy link
Copy Markdown

Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in HOW_TO_MARK.md in the root of this repository

Your Details

  • Your Name: nasir ali
  • Your City: glasgow
  • Your Slack Name: nasir ali

Homework Details

  • Module: JavaScript
  • Week: 1

Notes

  • What did you find easy?
    basic variables
  • What did you find hard?
    8 ball
  • What do you still not understand?
    8 ball
  • Any other notes?

Comment thread extra/3-magic-8-ball.js
*/
function checkAnswer(answer) {
function checkAnswer(main_moods_selection) {
//Write your code in here

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @ali-nasir-ali ,
Thank your submission - seeing some great work here! Excellent start!
Your tests for the extra section aren't quite passing at the moment. Here are a few things to consider:

  1. Look carefully at the test cases for checkAnswer:
test("checkAnswer works for `It is decidedly so.`", () => {
  expect(checkAnswer("It is decidedly so.")).toEqual("very positive");
});

Look carefully at how checkAnswer is being called here in this test. What argument is being passed to checkAnswer ?
Compare this with your current implementation of checkAnswer to see if you can figure out how to update the function.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Mitch Lloyd, with your help I finally figured out that the function name was literal not figurative. and was able to solve it by googling the write questions. Again many thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants