Precompute power if both arguments are constants (revisit) - #2330
Merged
Conversation
dcodeIO
reviewed
Jun 20, 2022
Member
|
Seems that the math test no longer tests ipow32 now. Would it perhaps be good to add another test there to test it? |
Member
Author
It tests in debug more only |
Member
|
Yeah, just wondering if there would be value in also testing ipow32 when it becomes optimized. Probably not super important, but who knows what can be seen from the optimized ipow32 code when it's modified in the future, hmm. |
Member
Author
|
I think testing in debug builds only is ok due to ipow32 is pretty simple and naive code. And if there is anything wrong with the optimizations from the release build it will appear very quickly in the rest of tests |
dcodeIO
approved these changes
Jun 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Precompute power operator when lhs and rhs are constants like:
Unlike the previous PR, this only happens in optimization mode. Also added comment and TODO
Prev PR #1529